-
-
Notifications
You must be signed in to change notification settings - Fork 17.4k
python313Packages.debugpy: make src reproducible #468328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
07a17bc to
7ef5f46
Compare
|
|
||
| patches = [ | ||
| # Use nixpkgs version instead of versioneer | ||
| (replaceVars ./hardcode-version.patch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No longer necessary since microsoft/debugpy#866
|
| sed -i 's/git_refnames = "[^"]*"/git_refnames = " (tag: ${src.tag})"/' "$out/src/debugpy/_version.py" | ||
| ''; | ||
|
|
||
| hash = "sha256-eAiCtSJUqLASapxnYCyq1UCiGz6QmKQum7Vs3MoU1s8="; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried that the hash didn't change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upstream uses
.gitattributesto inject information about the revision hash and the refname intosrc/debugpy/_version.py.This fix explicitly replaces the contents of
git_refnamesto ensure the source is reproducible.Previously, if the version fetched was the HEAD commit of the repo, we would have:
instead of
Here are some previous cases where this was a problem:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.