fix: handle caret and tilde in runtime versions (#5501)

janoshrubos · web-flow · commit 04eba0deb506 · 2021-03-26T23:41:01.000+01:00
diff --git a/lib/controllers/migrate-controller.ts b/lib/controllers/migrate-controller.ts
@@ -1128,7 +1128,7 @@ export class MigrateController
 		allowInvalidVersions: boolean
 	): boolean {
 		return !!version
-			? semver.lt(version, targetVersion)
+			? semver.lt(semver.coerce(version), targetVersion)
 			: !allowInvalidVersions;
 	}
 
diff --git a/lib/services/project-config-service.ts b/lib/services/project-config-service.ts
@@ -372,7 +372,7 @@ export default {
 
 		if (
 			runtimePackage.version &&
-			semver.gte(runtimePackage.version, "7.0.0-rc.5")
+			semver.gte(semver.coerce(runtimePackage.version), "7.0.0-rc.5")
 		) {
 			// runtimes >= 7.0.0-rc.5 support passing appPath and appResourcesPath through gradle project flags
 			// so writing an nsconfig is not necessary.

Original file line number	Diff line number	Diff line change
`@@ -1128,7 +1128,7 @@ export class MigrateController`
`1128`	`1128`	`allowInvalidVersions: boolean`
`1129`	`1129`	`): boolean {`
`1130`	`1130`	`return !!version`
`1131`		`- ? semver.lt(version, targetVersion)`
	`1131`	`+ ? semver.lt(semver.coerce(version), targetVersion)`
`1132`	`1132`	`: !allowInvalidVersions;`
`1133`	`1133`	`}`
`1134`	`1134`