You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The return_blank_recipe() function currently has two responsibilities: loading a recipe, and removing the contents of the dataset section. These responsibilities should be separated into a load_yaml function and a remove_dataset_contents function, making the purpose of each function clearer.
Test the new remove_dataset_contents function by passing in an already-loaded recipe and confirming the returned recipe has an empty dataset section. There is no need to test the load_yaml function.
The add_extra_datasets() function currently has three responsibilities: loading the dataset information, constructing the dataset section for a recipe, and adding the dataset section to the recipe. These responsibilities should be separated into a load_yaml function, a construct_dataset_contents function and a add_dataset_contents function, making the purpose of each function clearer.
Test the new construct_dataset_contents function and add_dataset_contents function. There is no need to test the load_yaml function.
Remove the KGOs.
The update_recipe_file() function is the "driver" function. Are other driver functions currently being tested?
./app/unittest/kgo/blank_recipe_radiation_budget.ymlload_yamlfunction and aremove_dataset_contentsfunction, making the purpose of each function clearer.remove_dataset_contentsfunction by passing in an already-loaded recipe and confirming the returned recipe has an empty dataset section. There is no need to test theload_yamlfunction../app/unittest/kgo/extended_radiation_budget_recipe.ymlload_yamlfunction, aconstruct_dataset_contentsfunction and aadd_dataset_contentsfunction, making the purpose of each function clearer.construct_dataset_contentsfunction andadd_dataset_contentsfunction. There is no need to test theload_yamlfunction.