Merge pull request #309 from MerginMaps/fix/qgis-plugin-security-b105

Fix plugins.qgis.org security-review findings

Author: harminius

mergin/cli.py

@@ -624,8 +624,8 @@ def remove(ctx, project):
     if "/" in project:
         try:
             namespace, project = project.split("/")
-            assert namespace, "No namespace given"
-            assert project, "No project name given"
+            assert namespace, "No namespace given"  # nosec B101
+            assert project, "No project name given"  # nosec B101
         except (ValueError, AssertionError) as e:
             click.secho(f"Incorrect namespace/project format: {e}", fg="red")
             return

mergin/client.py

@@ -92,11 +92,11 @@ class ServerType(Enum):
 
 
 def decode_token_data(token):
-    token_prefix = "Bearer "
-    if not token.startswith(token_prefix):
+    bearer_prefix = "Bearer "
+    if not token.startswith(bearer_prefix):
         raise TokenError(f"Token doesn't start with 'Bearer ': {token}")
     try:
-        token_raw = token[len(token_prefix) :]
+        token_raw = token[len(bearer_prefix) :]
         is_compressed = False
 
         # compressed tokens start with dot,

mergin/client_pull.py

@@ -694,7 +694,7 @@ def pull_project_finalize(job: PullJob):
     job.mp.log.info("finalizing pull")
     try:
         if job.v2_pull_enabled:
-            assert job.project_info is None
+            assert job.project_info is None  # nosec B101
 
             project_info_response = job.mc.project_info_v2(job.mp.project_id(), files_at_version=job.version)
             job.project_info = asdict(project_info_response)