Skip to content

Commit 47a98f2

Browse files
authored
Bump min version to PHP 7.3 (#617)
1 parent a788a8f commit 47a98f2

File tree

4 files changed

+24
-21
lines changed

4 files changed

+24
-21
lines changed

.github/workflows/code_checks.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ jobs:
2121

2222
-
2323
name: 'Rector CI'
24-
run: composer rector
24+
run: vendor/bin/rector process --dry-run --ansi
2525

2626
name: ${{ matrix.actions.name }}
2727
runs-on: ubuntu-latest

composer.json

Lines changed: 18 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -11,32 +11,32 @@
1111
{ "name": "Knplabs", "homepage": "http://knplabs.com" }
1212
],
1313
"require": {
14-
"php": "^7.2|^8.0",
15-
"doctrine/common": "^2.7|^3.0",
16-
"doctrine/persistence": "^1.3.4|^2.0",
14+
"php": ">=7.3",
15+
"doctrine/common": "^3.0",
16+
"doctrine/persistence": "^2.0",
1717
"doctrine/dbal": "^2.9",
18-
"doctrine/orm": "^2.7",
19-
"symfony/cache": "^4.4|^5.1",
20-
"symfony/dependency-injection": "^4.4|^5.1",
21-
"symfony/http-kernel": "^4.4|^5.1",
22-
"symfony/security-core": "^4.4|^5.1",
23-
"symfony/framework-bundle": "^4.4|^5.1",
24-
"symfony/string": "^5.0",
25-
"symfony/translation-contracts": "^2.1",
26-
"nette/utils": "^3.0",
27-
"ramsey/uuid": "^3.9|^4.0",
28-
"symfony/polyfill-php80": "^1.18"
18+
"doctrine/orm": "^2.8",
19+
"symfony/cache": "^4.4|^5.2",
20+
"symfony/dependency-injection": "^4.4|^5.2",
21+
"symfony/http-kernel": "^4.4|^5.2",
22+
"symfony/security-core": "^4.4|^5.2",
23+
"symfony/framework-bundle": "^4.4|^5.2",
24+
"symfony/string": "^5.2",
25+
"symfony/translation-contracts": "^2.3",
26+
"nette/utils": "^3.2",
27+
"ramsey/uuid": "^4.0",
28+
"symfony/polyfill-php80": "^1.22"
2929
},
3030
"require-dev": {
3131
"ext-pdo_sqlite": "*",
3232
"ext-pdo_mysql": "*",
3333
"ext-pdo_pgsql": "*",
3434
"psr/log": "^1.1",
35-
"doctrine/annotations": "^1.8",
36-
"doctrine/doctrine-bundle": "^2.0",
35+
"doctrine/annotations": "^1.12",
36+
"doctrine/doctrine-bundle": "^2.2",
3737
"php-parallel-lint/php-parallel-lint": "^1.2",
3838
"phpstan/phpstan": "^0.12.80",
39-
"phpunit/phpunit": "^8.5|^9.2",
39+
"phpunit/phpunit": "^9.5",
4040
"rector/rector-prefixed": "^0.9",
4141
"symplify/easy-coding-standard": "^9.2.6",
4242
"symplify/phpstan-extensions": "^9.2.6",
@@ -59,7 +59,6 @@
5959
"scripts": {
6060
"check-cs": "vendor/bin/ecs check --ansi",
6161
"fix-cs": "vendor/bin/ecs check --fix --ansi",
62-
"phpstan": "vendor/bin/phpstan analyse --ansi --error-format symplify",
63-
"rector": "vendor/bin/rector process --dry-run"
62+
"phpstan": "vendor/bin/phpstan analyse --ansi --error-format symplify"
6463
}
6564
}

rector.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,10 @@
1818
SetList::CODING_STYLE,
1919
SetList::NETTE_UTILS_CODE_QUALITY,
2020
SetList::NAMING,
21+
SetList::PHP_70,
22+
SetList::PHP_71,
23+
SetList::PHP_72,
24+
SetList::PHP_73,
2125
]);
2226

2327
$parameters->set(Option::SKIP, [

src/Model/Tree/TreeNodeMethodsTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ public function addChildNode(TreeNodeInterface $treeNode): void
103103
public function isIndirectChildNodeOf(TreeNodeInterface $treeNode): bool
104104
{
105105
return $this->getRealMaterializedPath() !== $treeNode->getRealMaterializedPath()
106-
&& strpos($this->getRealMaterializedPath(), $treeNode->getRealMaterializedPath()) === 0;
106+
&& strpos($this->getRealMaterializedPath(), (string) $treeNode->getRealMaterializedPath()) === 0;
107107
}
108108

109109
public function isChildNodeOf(TreeNodeInterface $treeNode): bool

0 commit comments

Comments
 (0)