Skip to content

Set default stopping tolerances to epsilon^1/3 - #330

Merged
dpo merged 3 commits into
JuliaSmoothOptimizers:masterfrom
BenjaminPINEAU:relax_tol
May 5, 2026
Merged

Set default stopping tolerances to epsilon^1/3#330
dpo merged 3 commits into
JuliaSmoothOptimizers:masterfrom
BenjaminPINEAU:relax_tol

Conversation

@BenjaminPINEAU

Copy link
Copy Markdown
Contributor

Relax the stopping tolerances for the solvers (see #324).
Transition from $\sqrt{\epsilon_M}$ to $\epsilon^{1/3}_M$ @dpo

@MaxenceGollier MaxenceGollier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @BenjaminPINEAU!

Comment thread src/LMTR_alg.jl Outdated
Comment thread src/TR_alg.jl Outdated
BenjaminPINEAU and others added 2 commits May 5, 2026 11:27
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
Co-authored-by: Maxence Gollier <134112149+MaxenceGollier@users.noreply.github.com>
@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.85%. Comparing base (e0f214d) to head (5eedfc9).
⚠️ Report is 283 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #330       +/-   ##
===========================================
+ Coverage   61.53%   83.85%   +22.31%     
===========================================
  Files          11       12        +1     
  Lines        1292     1641      +349     
===========================================
+ Hits          795     1376      +581     
+ Misses        497      265      -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dpo dpo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@dpo
dpo merged commit 37a79db into JuliaSmoothOptimizers:master May 5, 2026
14 checks passed
@BenjaminPINEAU
BenjaminPINEAU deleted the relax_tol branch May 5, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants