From d4cf07664a44be9f174be2853a2b1818e4c88704 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Fuhrmann?= Date: Tue, 13 Jan 2026 13:25:48 +0100 Subject: [PATCH 1/4] Aqua, ExplicitImports --- README.md | 1 + docs/src/index.md | 10 ++++------ src/Triangulate.jl | 7 +++++-- test/Project.toml | 7 +++++++ test/runtests.jl | 27 ++++++++++++++++++++++++++- 5 files changed, 43 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index 578e83d..698d6f1 100644 --- a/README.md +++ b/README.md @@ -5,6 +5,7 @@ Triangulate [![](https://img.shields.io/badge/docs-stable-blue.svg)](https://juliageometry.github.io/Triangulate.jl/stable) [![PkgEval](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/T/Triangulate.svg)](https://juliaci.github.io/NanosoldierReports/pkgeval_badges/report.html) [![code style: runic](https://img.shields.io/badge/code_style-%E1%9A%B1%E1%9A%A2%E1%9A%BE%E1%9B%81%E1%9A%B2-black)](https://github.com/fredrikekre/Runic.jl) +[![Aqua QA](https://raw.githubusercontent.com/JuliaTesting/Aqua.jl/master/badge.svg)](https://github.com/JuliaTesting/Aqua.jl) Julia wrapper for Jonathan Richard Shewchuk's Triangle mesh generator. The package tries to provide a 1:1 mapping of Triangle's functionality to Julia. diff --git a/docs/src/index.md b/docs/src/index.md index 620ebb4..413a6d8 100644 --- a/docs/src/index.md +++ b/docs/src/index.md @@ -1,9 +1,7 @@ -````@eval -using Markdown -Markdown.parse(""" -$(read("../../README.md",String)) -""") -```` +```@docs +Triangulate +``` + ## Copyright information This is the copyright information of the original Triangle code. diff --git a/src/Triangulate.jl b/src/Triangulate.jl index 1c95b80..a3db73e 100644 --- a/src/Triangulate.jl +++ b/src/Triangulate.jl @@ -1,6 +1,9 @@ +""" +$(README) +""" module Triangulate -using DocStringExtensions -using Triangle_jll +using DocStringExtensions: DocStringExtensions, TYPEDEF, TYPEDFIELDS, TYPEDSIGNATURES, README +using Triangle_jll: Triangle_jll, libtriangle include("ctriangulateio.jl") include("triangulateio.jl") diff --git a/test/Project.toml b/test/Project.toml index fdf98ea..e105016 100644 --- a/test/Project.toml +++ b/test/Project.toml @@ -1,3 +1,10 @@ [deps] +Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" +ExplicitImports = "7d51a73a-1435-4ff3-83d9-f097790105c7" Printf = "de0858da-6303-5e67-8744-51eddeeeb8d7" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" + +[compat] +Aqua = "0.8" +ExplicitImports = "1.14" +julia = "1.9" diff --git a/test/runtests.jl b/test/runtests.jl index 1a12576..0f0d940 100644 --- a/test/runtests.jl +++ b/test/runtests.jl @@ -1,4 +1,6 @@ using Test +using Triangulate +using ExplicitImports, Aqua modname(fname) = splitext(basename(fname))[1] @@ -30,6 +32,29 @@ function run_tests_from_directory(testdir, prefix) end end -@time begin +@testset "functionality" begin run_tests_from_directory(@__DIR__, "test_") end + + +@testset "ExplicitImports" begin + @test ExplicitImports.check_no_implicit_imports(Triangulate, skip = (Base, Core)) === nothing + @test ExplicitImports.check_all_explicit_imports_via_owners(Triangulate) === nothing + @static if VERSION >= v"1.11.0" + @test ExplicitImports.check_all_explicit_imports_are_public(Triangulate) === nothing + @test ExplicitImports.check_all_qualified_accesses_are_public(Triangulate) === nothing + end + @test ExplicitImports.check_no_stale_explicit_imports(Triangulate, ignore = (:README,)) === nothing + @test ExplicitImports.check_all_qualified_accesses_via_owners(Triangulate) === nothing + @test ExplicitImports.check_no_self_qualified_accesses(Triangulate) === nothing +end + +@testset "Aqua" begin + Aqua.test_all(Triangulate) +end + +if isdefined(Docs, :undocumented_names) + @testset "UndocumentedNames" begin + @test isempty(Docs.undocumented_names(Triangulate)) + end +end From 35f8a96370eeb59fae25b1eb1866d059d36cd83b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Fuhrmann?= Date: Tue, 13 Jan 2026 13:27:06 +0100 Subject: [PATCH 2/4] CompatHelper->dependabot --- .github/dependabot.yml | 9 ++++-- .github/workflows/CompatHelper.yml | 44 ------------------------------ 2 files changed, 6 insertions(+), 47 deletions(-) delete mode 100644 .github/workflows/CompatHelper.yml diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 700707c..d9b5903 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,7 +1,10 @@ -# https://docs.github.com/github/administering-a-repository/configuration-options-for-dependency-updates version: 2 updates: - package-ecosystem: "github-actions" - directory: "/" # Location of package manifests + directory: "/" schedule: - interval: "weekly" + interval: "daily" + - package-ecosystem: "julia" + directory: "/" + schedule: + interval: "daily" diff --git a/.github/workflows/CompatHelper.yml b/.github/workflows/CompatHelper.yml deleted file mode 100644 index 5f42779..0000000 --- a/.github/workflows/CompatHelper.yml +++ /dev/null @@ -1,44 +0,0 @@ -name: CompatHelper -on: - schedule: - - cron: 0 0 * * * - workflow_dispatch: -permissions: - contents: write - pull-requests: write -jobs: - CompatHelper: - runs-on: ubuntu-latest - steps: - - name: Check if Julia is already available in the PATH - id: julia_in_path - run: which julia - continue-on-error: true - - name: Install Julia, but only if it is not already available in the PATH - uses: julia-actions/setup-julia@v2 - with: - version: '1' - arch: ${{ runner.arch }} - if: steps.julia_in_path.outcome != 'success' - - name: "Add the General registry via Git" - run: | - import Pkg - ENV["JULIA_PKG_SERVER"] = "" - Pkg.Registry.add("General") - shell: julia --color=yes {0} - - name: "Install CompatHelper" - run: | - import Pkg - name = "CompatHelper" - uuid = "aa819f21-2bde-4658-8897-bab36330d9b7" - version = "3" - Pkg.add(; name, uuid, version) - shell: julia --color=yes {0} - - name: "Run CompatHelper" - run: | - import CompatHelper - CompatHelper.main() - shell: julia --color=yes {0} - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - COMPATHELPER_PRIV: ${{ secrets.DOCUMENTER_KEY }} From 1192c29dc7af32d547269e080ee177b3880f4a0c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Fuhrmann?= Date: Tue, 13 Jan 2026 13:28:02 +0100 Subject: [PATCH 3/4] remove test on macos-13 --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c7527ba..a7981e5 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,6 @@ jobs: os: - ubuntu-latest - windows-latest - - macOS-13 # intel - macOS-latest # arm arch: - x64 @@ -31,8 +30,6 @@ jobs: arch: aarch64 - os: windows-latest arch: aarch64 - - os: macOS-13 - arch: aarch64 - os: macOS-latest arch: x64 steps: From 305cc8a63b7a23ccf89088cc4bae7e7d1a37d9b2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BCrgen=20Fuhrmann?= Date: Tue, 13 Jan 2026 13:33:23 +0100 Subject: [PATCH 4/4] bump patch version --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index fafa1ad..1a993d7 100644 --- a/Project.toml +++ b/Project.toml @@ -1,7 +1,7 @@ name = "Triangulate" uuid = "f7e6ffb2-c36d-4f8f-a77e-16e897189344" authors = ["Juergen Fuhrmann "] -version = "3.0.0" +version = "3.0.1" [deps] DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"