API review: widen annotations, rename prepare_mm_package, expose parallel keyword, bump to v1.0.1#27
Conversation
`driver` and `mm_package_loader` now accept any AbstractVector (not just Vector) and any AbstractDict (not just Dict), matching Base's convention of annotating with the abstract type the implementation can actually handle. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
`load_mm_package` (the originally planned target) collides with the same-named symbol imported from RegisterWorkerShell, which is the function the wrapper delegates to. `prepare_mm_package` is verb-first, non-colliding, and reads naturally for its role: prepare the device-specific mismatch backend before calling `driver`. No deprecation shim per stated values (clean break). Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Add `parallel::Bool = length(algorithms) > 2` to `driver`'s multi-worker signature, making the threading threshold explicitly configurable. The default preserves existing dispatch exactly. Add a four-case testset covering both branches. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Release all API-review improvements as v1.0.1. Also narrow RegisterCore and RegisterWorkerShell compat from "0.2, 1" → "1"; the package has required 1.x semantics since v1.0.0 and the 0.2 entries were vestigial. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 91.26% 91.74% +0.48%
==========================================
Files 1 1
Lines 103 109 +6
==========================================
+ Hits 94 100 +6
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vector→AbstractVectorandDict→AbstractDictacross alldriverandprepare_mm_packagesignatures, allowing sparse, GPU, ordered, and other subtypes withoutMethodError.mm_package_loader→prepare_mm_package(breaking): aligns with Julia's verb-first naming convention; the old name collided with the importedRegisterWorkerShell.load_mm_package, soprepare_mm_packagewas chosen as the non-colliding target. No deprecation shim (clean break per project policy).parallelkeyword ondrivermethod 1:parallel::Bool = length(algorithms) > 2makes the threading threshold explicit. The default preserves existing behaviour exactly.RegisterCore/RegisterWorkerShellcompat from"0.2, 1"→"1"(vestigial 0.2 entries removed).Test plan
runtests.jl:88is unrelated to these changes)@testset "parallel keyword"exercisesparallel=falseandparallel=truebranchesgrepconfirms zero remaining references tomm_package_loaderin source and docsProject.tomlshowsversion = "1.0.1"@JuliaRegistrator registeron the merge commit🤖 Generated with Claude Code