Skip to content

fix(web): align site brand strings and tidy redesign leftovers#4366

Merged
Hmbown merged 2 commits into
mainfrom
claude/codewhale-v0.8.68-test-review-zsphu7
Jul 14, 2026
Merged

fix(web): align site brand strings and tidy redesign leftovers#4366
Hmbown merged 2 commits into
mainfrom
claude/codewhale-v0.8.68-test-review-zsphu7

Conversation

@Hmbown

@Hmbown Hmbown commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

Follow-ups to the #4362 documentation-led redesign, addressing the four non-blocking findings from its review pass:

  • Align user-visible brand strings across all web pages to the "Codewhale" wordmark the redesign introduced — repo URLs and the Hmbown/CodeWhale slug are untouched.
  • Deduplicate the homepage topic special-cases: topicHref() and TopicList now share one TOPIC_PAGE_OVERRIDES map instead of two hardcoded id lists that could drift.
  • Replace the stale pre-rebrand ink rgba(14,14,16,…) with the palette ink rgb(27,34,48) in globals.css and the mobile menu divider.
  • Remove the dead .site-install-link CSS now that the desktop nav no longer renders an Install button.

Testing

Web-only change, so the Rust gates don't apply:

  • eslint . — clean

  • vitest run — 42 tests passed

  • node scripts/check-docs.mjs — PASS

  • Next.js production build — compiled, all 39 pages generated

  • cargo fmt --all -- --check (n/a — no Rust changes)

  • cargo clippy --workspace --all-targets --all-features (n/a)

  • cargo test --workspace --all-features (n/a)

Checklist

  • Updated docs or comments as needed
  • Added or updated tests where relevant (existing web tests cover the touched pages)
  • Verified TUI behavior manually if UI changes (n/a — public site only)
  • Harvested/co-authored credit uses a GitHub numeric noreply address (n/a — no harvested work)

🤖 Generated with Claude Code

https://claude.ai/code/session_01LDgEjx15zGLkE5gCuWFVWu


Generated by Claude Code

claude and others added 2 commits July 14, 2026 04:48
Follow-ups to the #4362 documentation-led redesign, addressing the four
non-blocking findings from its review:

- Align user-visible brand strings across all web pages to the
  "Codewhale" wordmark the redesign introduced (repo URLs and the
  Hmbown/CodeWhale slug are untouched).
- Deduplicate the homepage topic special-cases: topicHref() and
  TopicList now share one TOPIC_PAGE_OVERRIDES map instead of two
  hardcoded id lists that could drift.
- Replace the stale pre-rebrand ink rgba(14,14,16,...) with the
  palette ink rgb(27,34,48) in globals.css and the mobile menu divider.
- Remove the dead .site-install-link CSS now that the desktop nav no
  longer renders an Install button.

Verified with eslint, 42 web tests, check-docs, and a full Next.js
production build (39 pages).

Prepared with agent assistance.
Git clones the technical CodeWhale repository slug into a case-matching directory by default, so keep the following cd command exact for case-sensitive filesystems. Extend the docs drift gate to reject future clone-directory casing mismatches.

Signed-off-by: Hunter B <hmbown@gmail.com>
@Hmbown Hmbown marked this pull request as ready for review July 14, 2026 11:14
Copilot AI review requested due to automatic review settings July 14, 2026 11:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@claude

claude Bot commented Jul 14, 2026

Copy link
Copy Markdown

Claude finished @Hmbown's task in 3m 34s —— View job


Review: fix(web): align site brand strings and tidy redesign leftovers

  • Gather context (diff, changed files, custom review priorities)
  • Review brand-string alignment changes
  • Review TOPIC_PAGE_OVERRIDES dedup in homepage
  • Review CSS/ink color changes
  • Review check-docs.mjs changes
  • Post final review

This is a clean, low-risk follow-up PR. I reviewed the full diff (c220abd...HEAD, matches the stated 165/-136 across 25 files). Findings below, in priority order per repo review guidelines.

Correctness: No bugs found. Nothing here touches provider/model routing (repo review priority #2 doesn't apply — this is UI text/CSS/lint tooling only).

web/scripts/check-docs.mjs (new source-checkout casing gate):

  • checkInstallSnippets() now also parses the FROM_SOURCE snippet's git clone .../<repo> + cd <dir> pair and fails the gate if they don't match casing. Logic checked by hand: the regex /git clone https:\/\/github\.com\/Hmbown\/([^\s\]+)\s*\ncd\s+([^\s\`]+)/correctly matches the actual snippet ininstall/page.tsx:56-57 (git clone https://github.com/Hmbown/CodeWhale` / cd CodeWhale), and .git suffix stripping is handled. Good defensive addition given the wordmark rename — this is what keeps the one remaining literal CodeWhale string (the repo-slug-derived clone dir) honest.
  • Minor: this script isn't covered by vitest (consistent with how the rest of check-docs.mjs was already untested pre-PR, so not a new gap introduced by this change — just noting for awareness).

Homepage dedup (web/app/[locale]/page.tsx): TOPIC_PAGE_OVERRIDES cleanly replaces the two hardcoded id !== "install" && id !== "providers" checks with one map used by both topicHref() and topicIsExternal(). Correct and exactly the dedup described in the PR body — no drift risk left between the two call sites.

Brand string sweep: Spot-checked every touched page (faq, contribute, runtime, community, constitution, digest, docs/*, models, roadmap, feed, install) plus the prompt strings in lib/community-agent.ts, lib/deepseek.ts, lib/content-watch.ts. All are straightforward "CodeWhale" → "Codewhale" wordmark swaps; command names (codewhale), the codewhale.net domain, and Hmbown/CodeWhale repo-slug references are correctly left untouched, matching the PR's stated scope. Confirmed via grep that no stray CodeWhale wordmark instances remain outside the one guarded by the new check-docs gate.

One thing worth a quick sanity check (not a blocker): in contribute/page.tsx, the fork bootstrap snippet was changed from git clone git@github.com:YOU/CodeWhale / cd CodeWhale to .../YOU/Codewhale / cd Codewhale. A real GitHub fork actually inherits the upstream repo's exact case (CodeWhale), not the wordmark's lowercase w — so a contributor pasting this verbatim would still successfully clone (GitHub repo lookups are case-insensitive) and end up with a local directory named Codewhale, which is harmless but doesn't literally match their fork's on-disk GitHub name. Since this placeholder isn't the canonical Hmbown/CodeWhale slug the PR says is untouched, this looks like an intentional call to keep the snippet visually aligned with the new wordmark rather than an oversight — just flagging so it's a conscious choice rather than a missed case.

CSS (globals.css, mobile-menu.tsx): rgba(14,14,16,…)rgb(27,34,48,…) swap and .site-install-link removal are both verified as dead-code/stale-color cleanup with no remaining references (.site-install-link was only referenced in the deleted rules).

Testing: I wasn't able to re-run eslint/vitest/the Next.js build in this sandboxed review environment (network/npm execution isn't permitted here), so I relied on static review of the diff rather than re-verifying the PR's reported "42 tests passed" / clean build claims.

Nice, tightly-scoped follow-up — no changes requested.

@Hmbown Hmbown merged commit 352e86a into main Jul 14, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants