fix(web): align site brand strings and tidy redesign leftovers#4366
Conversation
Follow-ups to the #4362 documentation-led redesign, addressing the four non-blocking findings from its review: - Align user-visible brand strings across all web pages to the "Codewhale" wordmark the redesign introduced (repo URLs and the Hmbown/CodeWhale slug are untouched). - Deduplicate the homepage topic special-cases: topicHref() and TopicList now share one TOPIC_PAGE_OVERRIDES map instead of two hardcoded id lists that could drift. - Replace the stale pre-rebrand ink rgba(14,14,16,...) with the palette ink rgb(27,34,48) in globals.css and the mobile menu divider. - Remove the dead .site-install-link CSS now that the desktop nav no longer renders an Install button. Verified with eslint, 42 web tests, check-docs, and a full Next.js production build (39 pages). Prepared with agent assistance.
Git clones the technical CodeWhale repository slug into a case-matching directory by default, so keep the following cd command exact for case-sensitive filesystems. Extend the docs drift gate to reject future clone-directory casing mismatches. Signed-off-by: Hunter B <hmbown@gmail.com>
|
Claude finished @Hmbown's task in 3m 34s —— View job Review: fix(web): align site brand strings and tidy redesign leftovers
This is a clean, low-risk follow-up PR. I reviewed the full diff ( Correctness: No bugs found. Nothing here touches provider/model routing (repo review priority #2 doesn't apply — this is UI text/CSS/lint tooling only).
Homepage dedup ( Brand string sweep: Spot-checked every touched page ( One thing worth a quick sanity check (not a blocker): in CSS ( Testing: I wasn't able to re-run Nice, tightly-scoped follow-up — no changes requested. |
Summary
Follow-ups to the #4362 documentation-led redesign, addressing the four non-blocking findings from its review pass:
Hmbown/CodeWhaleslug are untouched.topicHref()andTopicListnow share oneTOPIC_PAGE_OVERRIDESmap instead of two hardcoded id lists that could drift.rgba(14,14,16,…)with the palette inkrgb(27,34,48)inglobals.cssand the mobile menu divider..site-install-linkCSS now that the desktop nav no longer renders an Install button.Testing
Web-only change, so the Rust gates don't apply:
eslint .— cleanvitest run— 42 tests passednode scripts/check-docs.mjs— PASSNext.js production build — compiled, all 39 pages generated
cargo fmt --all -- --check(n/a — no Rust changes)cargo clippy --workspace --all-targets --all-features(n/a)cargo test --workspace --all-features(n/a)Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01LDgEjx15zGLkE5gCuWFVWu
Generated by Claude Code