fix: address clippy warnings

Author: JamesPatrickGill

gix-protocol/Cargo.toml

@@ -59,7 +59,6 @@ fetch = [
 ## If set, blocking server-side protocol implementations are available.
 blocking-server = [
     "gix-transport/blocking-server",
-    "maybe-async/is_sync",
     "serve",
 ]
 ## Add implementations for serving (upload-pack).

gix-protocol/src/serve/ref_advertisement.rs

@@ -18,7 +18,7 @@ pub fn write_v1<W: Write>(writer: &mut W, refs: &[RefAdvertisement<'_>], capabil
             })
         })
         .collect();
-    all_caps.extend(capabilities.iter().map(|c| c.to_string()));
+    all_caps.extend(capabilities.iter().map(ToString::to_string));
     let caps = all_caps.join(" ");
 
     if refs.is_empty() {

gix-protocol/src/serve/upload_pack/function.rs

@@ -30,7 +30,8 @@ pub fn serve_upload_pack_v1<R: Read, W: Write>(
     let wants = parse_wants(&mut connection.line_provider)?;
     if wants.wants.is_empty() {
         return Ok(());
-    };
+    }
+
     connection.line_provider.reset();
 
     let mut common = Vec::new();
@@ -59,7 +60,7 @@ pub fn serve_upload_pack_v1<R: Read, W: Write>(
         write_ack(&mut connection.writer, last, AckStatus::Final)?;
     } else {
         write_nak(&mut connection.writer)?;
-    };
+    }
 
     let want_ids: Vec<ObjectId> = wants.wants.iter().map(|w| w.id).collect();
     generate_pack(&want_ids, &common, &mut connection.writer)?;

gix-protocol/src/serve/upload_pack/want_haves.rs

@@ -72,7 +72,7 @@ pub fn parse_wants<R: Read>(reader: &mut StreamingPeekableIter<R>) -> Result<Wan
 
                 if is_first {
                     if let Some(caps) = caps_str {
-                        capabilities = caps.split(|b| *b == b' ').map(|c| c.into()).collect();
+                        capabilities = caps.split(|b| *b == b' ').map(Into::into).collect();
                     }
                     is_first = false;
                 }

gix-serve/src/serve.rs

@@ -9,7 +9,7 @@ use gix_protocol::serve::{
 use gix_ref::file::Store;
 use gix_transport::{server::blocking_io::connection::Connection, Protocol};
 
-use crate::{refs::collect_refs, AdvertisableRef};
+use crate::{pack::generate_pack, refs::collect_refs, AdvertisableRef};
 
 impl AdvertisableRef {
     /// Borrow as a `RefAdvertisement` for the protocol layer.
@@ -18,7 +18,7 @@ impl AdvertisableRef {
             name: &self.name,
             object_id: &self.object_id,
             peeled: self.peeled.as_deref(),
-            symref_target: self.symref_target.as_ref().map(|s| s.as_ref()),
+            symref_target: self.symref_target.as_ref().map(AsRef::as_ref),
         }
     }
 }
@@ -48,7 +48,7 @@ pub fn serve_upload_pack<R: Read, W: Write, F: Find + Send + Clone + 'static>(
     let has_object = |oid: &oid| db.contains(oid);
 
     let generate_pack = |wants: &[ObjectId], haves: &[ObjectId], out: &mut dyn Write| {
-        crate::pack::generate_pack(db.clone(), wants, haves, out).map_err(|e| io::Error::new(io::ErrorKind::Other, e))
+        generate_pack(db.clone(), wants, haves, out).map_err(io::Error::other)
     };
 
     match protocol {

gix-serve/tests/upload_pack.rs

@@ -116,7 +116,7 @@ fn v1_empty_wants() {
     serve_upload_pack(&store, db, &mut conn, Protocol::V1).unwrap();
 
     assert!(!output.is_empty());
-    assert!(output.windows(4).position(|w| w == b"PACK").is_none());
+    assert!(!output.windows(4).any(|w| w == b"PACK"));
 }
 
 #[test]