Skip to content

Fix 14 Failing Tests (TabbedPane, Dialog, Panel) #223

@sfloess

Description

@sfloess

Summary

There are 14 test failures unrelated to recent 3D theme work that need investigation and fixes.

Test Failure Breakdown

TabbedPane Tests (8 failures)

  • FrameTest: 1 failure (27 tests total)
  • JFrameTest: 1 failure (27 tests total)
  • TabbedPaneTest: 4 failures (15 tests total)
  • JTabbedPaneTest: 4 failures (15 tests total)

Likely Issue: Tab bracketing display, possibly related to border character handling or theme integration changes.

Dialog Tests (4 failures)

Likely Issue: Title rendering, possibly related to border character changes or theme updates.

Panel Tests (2 failures)

Likely Issue: No-border rendering expecting space character but getting '+' character instead.

Test Results

Tests run: 1,466
Passed: 1,452
Failed: 14
Errors: 0
Skipped: 0
Success Rate: 99.0%

Context

These failures appeared after:

  • Theme system enhancements (Theme3D, multiple new themes)
  • Border character handling improvements
  • Component visibility API additions
  • 3D shadow rendering implementation

The failures are NOT in shadow rendering or 3D theme tests - those all pass. This suggests the issues are in:

  1. Border character selection/rendering logic
  2. Theme integration with existing components
  3. Character escaping or encoding in test expectations

Investigation Steps

  1. Run failing tests individually to see exact assertion failures
  2. Check if border character changes affected tab/dialog/panel rendering
  3. Verify theme integration doesn't break flat rendering
  4. Check if test expectations need updating for new border characters

Acceptance Criteria

  • All 1,466 tests pass (100% success rate)
  • TabbedPane tab display renders correctly with all themes
  • Dialog title rendering works correctly
  • Panel no-border mode renders as expected
  • No regressions in existing functionality

Related Files

  • src/test/java/org/flossware/curses/api/containers/FrameTest.java
  • src/test/java/org/flossware/curses/api/containers/JFrameTest.java
  • src/test/java/org/flossware/curses/api/TabbedPaneTest.java
  • src/test/java/org/flossware/curses/api/JTabbedPaneTest.java
  • src/main/java/org/flossware/curses/api/TabbedPane.java
  • src/main/java/org/flossware/curses/api/Dialog.java
  • src/main/java/org/flossware/curses/api/Panel.java

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtestingTest coverage and quality

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions