Skip to content
This repository was archived by the owner on Aug 12, 2022. It is now read-only.
This repository was archived by the owner on Aug 12, 2022. It is now read-only.

2 issues in @post '/applications/{applicationId}/deploy'  #345

Description

@zongzw

Reference:

  1. Since we create the partition, we need not the following code:
        /*Turn to Deploy method */
        let newReq = new AS3DeployRequest(adc, application, declaration);
        await asgManager.deploy(
          mgmt.connection!.ipAddress,
          mgmt.connection!.tcpPort,
          newReq.declaration,
  1. The deployment process doesn't check VIP address availability, as '
    await this.TryBindVirtualAddressToExt(adc, declBody, addon);
    ' does.
    Recommend that merge @post '/applications/{applicationId}/deploy' and @post('/applications/{applicationId}/declarations/{declarationId}/deploy', together.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions