Problem
tests/source-mode.sh checks FAILED and exits at lines 477-480, but continues adding assertions afterward. Failures in the later source-mode migration and manifest assertions increment FAILED without another final failure gate, so the script exits 0.
Observed while running the full suite for #341 on current main:
FAIL recorded 'managed' resolves to owned on upgrade
got: workspace
want: owned
FAIL record_mode does not rewrite an already-migrated install
got: option update wp_coding_agents_source_mode workspace
want:
The script then continued and returned success.
Expected
Move or repeat the FAILED exit gate after all assertions so any late failure makes the CI job fail. Investigate the two currently exposed source-mode regressions separately from the harness fix.
Problem
tests/source-mode.shchecksFAILEDand exits at lines 477-480, but continues adding assertions afterward. Failures in the later source-mode migration and manifest assertions incrementFAILEDwithout another final failure gate, so the script exits 0.Observed while running the full suite for #341 on current
main:The script then continued and returned success.
Expected
Move or repeat the
FAILEDexit gate after all assertions so any late failure makes the CI job fail. Investigate the two currently exposed source-mode regressions separately from the harness fix.