Skip to content

Fix contradictory CallerContext outbound agent assertions #3324

Description

@chubes4

Problem

tests/Unit/Auth/CallerContextTest.php constructs outbound contexts with caller_agent_id set to remote-agent, then asserts that the value is franklin:

  • test_outbound_fresh_chain_shape
  • test_outbound_propagates_inbound_chain

The object correctly preserves the constructor value, so both assertions fail in Homeboy shard 3. The failure reproduces on PR #3323 and is unrelated to that PR's layer-purity changes.

Expected

The tests should assert remote-agent, matching the explicit constructor input and the test's current-site-not-inbound intent.

Evidence

Homeboy run 32605703686, candidate shard 3, failed both tests on two consecutive attempts while all other candidate shards passed.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions