[Sentry: APP-JWE / APP-JWD] Web ReferenceError: getAllReportActions is not defined in updateSplitTransactions

[mountiny]

Sentry

• https://expensify.sentry.io/issues/APP-JWE (3 users, 37 events)
• https://expensify.sentry.io/issues/APP-JWD (1 user, 6 events)

Same ReferenceError, same function, different routes. Sentry split them by route.

Impact (snapshot at filing)

• Users (last 7d): 4 across both groups
• Users (total since first seen): 4
• Events: 43
• First seen: 2026-08-06
• Last seen: 2026-08-06
• Platform: web (Chrome)
• App version(s): 9.4.51-0
• Environment: production
• Affected route(s) (parameterized): /r/:reportID/:reportActionID, /create/split-expense/overview/:reportID/:transactionID/...
• Mechanism: auto.browser.browserapierrors.requestAnimationFrame
• Substatus: escalating

Stack trace (top frames)

app:///7572-<hash>.bundle.js:1:142600
app:///7572-<hash>.bundle.js:1:117469 (updateSplitTransactions)

The bundle is minified, but the enclosing function name survives: updateSplitTransactions.

Suspected cause

getAllReportActions is called inside updateSplitTransactions but is not in scope there — a missing or dropped import. This is a plain ReferenceError, so the call site fails every time it is reached; it is not a data-dependent edge case.

The call runs inside a requestAnimationFrame callback, which is why it escapes as an unhandled error rather than surfacing in a promise chain.

Grep the split expense update path for getAllReportActions and confirm it is imported in the module that defines updateSplitTransactions.

Reproduction

Open a split expense and trigger the update path that calls updateSplitTransactions. Because the symbol is simply undefined, any user reaching that line hits the crash.

• Verify that no errors appear in the JS console

Related

• Parent tracker: [Tracking] Top Sentry crashes monthly check-in #91302

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022086528459652676594
• Upwork Job ID: 2086528459652676594
• Last Price Increase: 2026-08-09

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cretadn22 (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022086528459652676594

[MelvinBot]

Issue Analysis

Root Cause (correcting the filed hypothesis): This is not a missing/dropped import — the source is correct. getAllReportActions is imported in updateSplitTransactions' module, at the exact version that crashed (9.4.51-0 → tag 963838851): SplitTransactionUpdate.ts:18-29, and it is exported from ReportActionsUtils.ts:4845. So grepping for the import and "adding it back" would be a no-op — the suggested fix does not apply.

The residual explanation is a transient build/bundle artifact in the 9.4.51-0 web deploy (the emitted chunk failed to wire the import binding, so the minifier left getAllReportActions as a bare unresolved identifier — which is exactly why the un-mangled name survives in a ReferenceError: ... is not defined). This is a compiled-artifact fault, not a source defect.

Recommended next step (not a contributor code change): Verify there is no recurrence on any version after 9.4.51-0. The signal strongly suggests it's already gone:

• First seen = Last seen = 2026-08-06, single version (9.4.51-0), 43 events / 4 users — then silent for 3 days.
• The current build was exercised live: creating a split and editing/re-saving it (the updateSplitTransactions path, UpdateSplitTransaction → 200) completes with no crash, no error UI, no failed request (screenshots above).

If Sentry confirms no events on later versions, this should be closed as a transient bad deploy of the 9.4.51-0 chunk rather than triaged as a code bug.

Investigation details & evidence

Why "missing import" is ruled out

• All six getAllReportActions call sites are lexically inside updateSplitTransactions (lines 299, 303, 389, 597, 1145, 1345) and the symbol is imported once at the top — verified present both on current main (3f4e1a1) and at the shipped tag 963838851.
• Git history shows the import was never removed and re-added; no PR references issue [Sentry: APP-JWE / APP-JWD] Web ReferenceError: getAllReportActions is not defined in updateSplitTransactions #98105. The only recent nearby change, Expensify/App#95745 (merged 2026-07-20), changed a getTrackExpenseActionableWhisper(...) call around line 1499 and did not touch the import block.

Why circular-dependency / TDZ is ruled out

• SplitTransactionUpdate.ts is in no import cycle — its only importers are leaf consumers (useDeleteTransactions.ts:7, SplitExpensePage.tsx:44); nothing reachable from ReportActionsUtils imports it back.
• getAllReportActions is a hoisted function declaration (ReportActionsUtils.ts:2030), so even under a bad init order the binding is hoisted — no temporal-dead-zone crash.

On the minified stack — the two frames (142600 throw / 117469 (updateSplitTransactions)) are within a single ~1,800-line scope-hoisted function; "is not defined" (vs "is not a function") is the signature of a missing binding in the compiled output, not a source-level undefined value.

To fully confirm the exact bundler behavior (internal tooling): pull the actual 9.4.51-0 web JS bundle + source map, locate offset 142600, and confirm a bare getAllReportActions was emitted, then diff its ReportActionsUtils linkage against a known-good build.

Confidence: High that the source is correct / the "add the import" fix is a no-op. Medium-high that the 9.4.51-0 crash was a transient bundle artifact (isolated to one version/one day, no recurrence, current build verified working).

---

Next Steps for Contributor+ team:
There is no contributor code change here — the import already exists, so please do not implement the filed "add the missing import" fix. Instead, confirm in Sentry whether APP-JWE / APP-JWD have any events past 9.4.51-0; if not, close as a transient bad deploy. Reply @MelvinBot <feedback> to refine this analysis.

Evidence (current build — split create + edit/update flow, no crash)

Split expense page splitting $1.00 into two $0.50 items

Two $0.50 Lunch split expenses after saving the initial split

Edit splits page for an already-split expense

Splits after re-saving the edited split (updateSplitTransactions edit path)

Final inbox state, no error indicators on the report

[cretadn22]

@MelvinBot Rather than relying on the module-level getAllReportActions function, we should use allReportActionsList parameter

[MelvinBot]

Agreed — and this supersedes my earlier "transient bad deploy, don't fix" conclusion. Using the allReportActionsList parameter is the correct, robust fix.

Why it's the right call: getAllReportActions is just a thin module-level wrapper — ReportActionsUtils.ts:2030 returns allReportActions?.[REPORT_ACTIONS + reportID] ?? {} from a module-scoped variable. updateSplitTransactions already receives that exact same collection as its allReportActionsList parameter (every caller sources it from useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS) — SplitExpensePage.tsx:373, useDeleteTransactions.ts:314). So the two are functionally identical, and the parameter form is already used in the same function (L387, L1603). Dropping the module-level call removes the very import binding that surfaced as ReferenceError: getAllReportActions is not defined, whatever its exact cause.

Recommended fix: Replace the 6 remaining getAllReportActions(<id>) calls with the parameter lookup, then drop the now-unused getAllReportActions import (L19). Each site becomes:

allReportActionsList?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${<id>}`] ?? {}

The 6 call sites and their id argument

Line	current arg	note
L299	revertSplitTransaction?.reportID	use site already has ?? {}
L303	splitTransactionThreadReportID	keep ?? {}
L389	firstIOU?.childReportID	keep ?? {}
L597	reportActionsReportID	keep ?? {}
L1145	remainTransactionThreadReportAction?.childReportID	keep ?? {}
L1345	reportActionsReportID	keep ?? {}

The trailing ?? {} matters: getAllReportActions never returns undefined, but the raw collection lookup can, and most of these results are iterated with Object.values(...).

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement this to create a draft PR with the above change.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting this approach.

[cretadn22]

@MelvinBot implement this

[MelvinBot]

🤖 Implementation paused — needs a scope decision before I open a PR.

I made the source change (swap the 6 module-level getAllReportActions(<id>) calls for allReportActionsList?.[…${id}] ?? {} and drop the now-unused import). It's production-safe and passes lint + typecheck — but it fails the existing split test suites for a reason that turns this from a mechanical swap into a larger change. I don't want to push a red PR or silently rewrite ~31 tests without your call.

Why it's not a drop-in swap: getAllReportActions reads ReportActionsUtils' module-level allReportActions (an independent Onyx.connect source). The allReportActionsList param is only equivalent when it's populated. In production it always is — both real callers pass the full useOnyx(REPORT_ACTIONS) collection (SplitExpensePage.tsx:373, useDeleteTransactions.ts:314) — so the swap is behavior-preserving there.

But ~31 test call sites across SplitTest.ts (25) and SplitSelfDMTest.ts (6) pass allReportActionsList: undefined (e.g. the shared splitToN helper at SplitTest.ts:5548) and lean on the module-level function as the actual data source. Once that fallback is gone, those lookups return {}, so ~30 split tests fail (thread-comment copying, hold-action creation, report-preview resolution — plus some cascade failures from a leaked jest spy once the first assertion throws).

To land this properly those tests need to pass the real collection (what the already-passing tests do: allReportActionsList: allReportActions), which makes them match production. That's legitimate but non-trivial: 31 sites across two files, each needing a fresh allReportActions in scope, and a few intentionally exercise the empty/absent case and must stay as-is — so it needs per-test judgment, not a blind find-replace.

Verified source diff (passes lint + typecheck)

@@ import block
-    getAllReportActions,
     getIOUActionForReportID,
@@ 6 call sites, each:
-    getAllReportActions(<id>)
+    allReportActionsList?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${<id>}`] ?? {}

Sites: L299, L303, L389, L597, L1145, L1345. ?? {} preserves getAllReportActions' never-undefined contract for the Object.values(...) consumers.

---

How do you want to proceed?

• @MelvinBot implement this including the test updates → I'll complete the source swap and migrate the affected undefined test call sites to pass the real collection, verify the split suites are green, and open the PR.
• Or, if you'd prefer to keep the source swap minimal and handle the test migration separately, let me know and I'll scope it that way.