[Sentry: APP-JRG / APP-JTG] HybridApp iOS OldDot crash in GuidedReviewManager — _getJobFromExpense(expense).isApproved on undefined

[mountiny]

Sentry

• https://expensify.sentry.io/issues/APP-JRG (8 users)
• https://expensify.sentry.io/issues/APP-JTG (3 users)

Both groups share the same throw site and the same platform. Sentry split them, but they are one bug.

Impact (snapshot at filing)

• Users (last 7d): 11 across both groups
• Users (total since first seen): 11
• Events: 11
• First seen: 2026-08-02
• Last seen: 2026-08-08
• Platform: iOS (HybridApp, OldDot)
• App version(s): 9.4.47-7 and later
• Mechanism: nsexception (fatal, uncaught)
• Culprit: -[YAPL logException:]

Stack trace (top frames, first-party only)

@app/managers/GuidedReviewManager.js:1749:44
    this._getJobFromExpense(expense).isApproved
@app/Controllers/GuidedReviewReportController.js:257:63
@app/Controllers/ReportController.js:972:63
@app/Controllers/ReportController.js:1129:63
@app/Controllers/ReportController.js:1122:19
@app/Controllers/ReportController.js:678:25
@app/Controllers/ReportController.js:225:32
publish@app/libs/pubSub.js:38:15
@app/libs/reportUtils.js:209:27

Native frames show the throw happening during ListViewController.removeRowAnimated, so the report list is mutating while the guided review state updates.

Suspected cause

_getJobFromExpense(expense) returns undefined and the caller reads .isApproved off it without a guard. The surrounding native frames point at a row being removed from the list at the same time, so the likely trigger is a guided review job that has already been consumed or removed when the pubSub update arrives for its expense.

The fix is to null-check the result of _getJobFromExpense at line 1749 and bail out when the job is gone.

Reproduction

Unknown. Sentry events all involve a report list update that removes a row while a guided review session is open.

Related

Other unhandled crashes in the same file, listed for context. They are separate throw sites and are not fixed by this issue:

Sentry ID	Users (last 7d)	Signature
APP-JRG (this issue)	8	_getJobFromExpense(expense).isApproved at line 1749
APP-JTG (this issue)	3	same throw site, separate Sentry group
APP-JVS	1	Error: Unable to find job for index 0 at line 586
APP-JW7	2	report.getID undefined at line 933 — already tracked in Expensify/Expensify#125773, labelled Not a priority

• Parent tracker: [Tracking] Top Sentry crashes monthly check-in #91302

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022086528447515527225
• Upwork Job ID: 2086528447515527225
• Last Price Increase: 2026-08-09

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022086528447515527225

[MelvinBot]

Issue Analysis

This crash cannot be fixed in Expensify/App. The throw site (GuidedReviewManager, GuidedReviewReportController, ReportController, pubSub, reportUtils) is OldDot client code that lives in a separate, internal Expensify repository — none of these files exist in the App codebase. This needs an internal engineer with access to that repo; a contributor working in App can't action it.

Root cause (from the stack trace): The hypothesis in the description holds up. _getJobFromExpense(expense) returns undefined and the caller immediately reads .isApproved off it with no guard, so undefined.isApproved throws a fatal, uncaught nsexception. The native frames (ListViewController.removeRowAnimated) show a report-list row being removed at the same moment a pubSub update fires for that expense — so the expense's guided-review job has already been consumed/removed by the time the update reaches the guarded read. Classic read-after-teardown race.

Recommended fix (for the internal owner): The defensive shape described in the issue is correct — null-check the _getJobFromExpense result and bail out when the job is gone, rather than reading .isApproved off it unconditionally. This should be implemented in the OldDot repo, not here.

Investigation details

• Confirmed not in App: grep/find for GuidedReviewManager and _getJobFromExpense across the App checkout returns nothing. These are OldDot (HybridApp iOS / OldDot) files, so the fix belongs in the internal repo that owns them.
• Scope of impact: 11 users across both Sentry groups (APP-JRG + APP-JTG), which share the same throw site — treating them as one bug is correct. Fatal/uncaught, so every occurrence is a hard crash.
• Why the guard is the right call: the trigger is a timing race (row removal vs. pubSub delivery), not a data-shape bug you can fully prevent upstream, so a defensive null-check at the read site is the appropriate mitigation.
• Alternative considered: the job could also be missing because of an ID mismatch (wrong expense→job lookup) rather than a removed job — but the surrounding removeRowAnimated frames point squarely at the teardown-race path, and either way the null-check safely handles both.
• Related throw sites (separate bugs, not fixed here): APP-JVS (line 586, "Unable to find job for index 0") and APP-JW7 (line 933, report.getID undefined — already tracked internally). These are distinct crashes in the same file and need their own guards.

---

This is an internal/OldDot fix, so there are no App-side implementation steps to accept. Please route it to an engineer with access to the OldDot repository. Reply with @MelvinBot <feedback> to refine this analysis.