Currently the Jungfrau has two implementations:
CommissioningJungfrau - https://github.com/DiamondLightSource/dodal/blob/working_commissioning_jf/src/dodal/devices/beamlines/i24/commissioning_jungfrau.py
Jungfrau - https://github.com/bluesky/ophyd-async/blob/5f878e85dc20236c0a56c7174a9a4d1dc4fea8fe/src/ophyd_async/fastcs/jungfrau/_detector.py#L10
The CommissioningJungfrau was needed because odin was not working and we needed a temporary file writer, which this uses, whereas Jungfrau uses odin. However, odin is now thought to be mostly working.
ophyd-async has recently updated the way that StandardDetectors need to be implemented, the Jungfrau detector in ophyd-async has been updated accordingly but ComissioningJungfrau has not.
Given the imminent dropping of ComissioningJungfrau it was decided (by @DominicOram and @phathaway) to not update it to the latest ophyd-async and instead remove it.
The ComissioningDetector remains on the beamline for testing as well as in the working_commissioning_jf branch if needed in the future.
However, this means there is the assumption that next time we update i24 it will be to use odin for the jungfrau.
Acceptance Criteria
- i24 is updated to use the Jungfrau in
ophyd-async
CommissioningJungfrau is removed from main
Currently the Jungfrau has two implementations:
CommissioningJungfrau- https://github.com/DiamondLightSource/dodal/blob/working_commissioning_jf/src/dodal/devices/beamlines/i24/commissioning_jungfrau.pyJungfrau- https://github.com/bluesky/ophyd-async/blob/5f878e85dc20236c0a56c7174a9a4d1dc4fea8fe/src/ophyd_async/fastcs/jungfrau/_detector.py#L10The
CommissioningJungfrauwas needed because odin was not working and we needed a temporary file writer, which this uses, whereasJungfrauuses odin. However, odin is now thought to be mostly working.ophyd-asynchas recently updated the way thatStandardDetectors need to be implemented, theJungfraudetector inophyd-asynchas been updated accordingly butComissioningJungfrauhas not.Given the imminent dropping of
ComissioningJungfrauit was decided (by @DominicOram and @phathaway) to not update it to the latestophyd-asyncand instead remove it.The
ComissioningDetectorremains on the beamline for testing as well as in theworking_commissioning_jfbranch if needed in the future.However, this means there is the assumption that next time we update i24 it will be to use odin for the jungfrau.
Acceptance Criteria
ophyd-asyncCommissioningJungfrauis removed frommain