Repository navigation
Commit eb91262
committed
fix(release-script): stage the showcase assets the cut regenerates
git applies an :(exclude) pathspec to the whole `git add` invocation rather than
to the pathspecs standing beside it. The generated-page globs carry
:(exclude)web/showcase, so that a file planted under the showcase cannot be
mistaken for a card page, and they were concatenated into the same add as the
showcase assets themselves - which the exclusion then cancelled. Measured on this
tree: the release commit's own pathspec list stages 0 paths under web/showcase,
and the same list without the exclusion stages 133.
So the v2.4.1 cut committed none of the 133 showcase files its own Step 4c had
just rewritten, and left them as working-tree churn under a tag that was supposed
to carry them - the site on main would have served the previous release's renders,
including the barcodes this release redraws.
The page globs now stage through an add of their own, where the exclusion reaches
only the globs it belongs to.
The CI step that owns these pathspecs lifts Get-GeneratedPagePathspecs by AST and
runs it alone, where the exclusion behaves correctly, so it passed throughout: it
tests the function, not the invocation the function's result ends up in.1 parent 092a619 commit eb91262
1 file changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1892 | 1892 | | |
1893 | 1893 | | |
1894 | 1894 | | |
1895 | | - | |
1896 | | - | |
| 1895 | + | |
| 1896 | + | |
| 1897 | + | |
| 1898 | + | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
1897 | 1902 | | |
1898 | 1903 | | |
1899 | 1904 | | |
| |||
1961 | 1966 | | |
1962 | 1967 | | |
1963 | 1968 | | |
| 1969 | + | |
| 1970 | + | |
| 1971 | + | |
1964 | 1972 | | |
1965 | 1973 | | |
1966 | 1974 | | |
| 1975 | + | |
| 1976 | + | |
| 1977 | + | |
1967 | 1978 | | |
1968 | 1979 | | |
1969 | 1980 | | |
| |||
0 commit comments