chore(dependencies): only depend on the windows crate when targeting windows#2024
Merged
Merged
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: d0af024 | Docs | Datadog PR Page | Give us feedback! |
yannham
approved these changes
May 21, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2024 +/- ##
==========================================
- Coverage 72.84% 72.82% -0.03%
==========================================
Files 458 458
Lines 75789 75789
==========================================
- Hits 55210 55191 -19
- Misses 20579 20598 +19
🚀 New features to boost your workflow:
|
hoolioh
approved these changes
May 21, 2026
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: removed
and removed
mergequeue-status: waiting
labels
`spawn_worker` and `datadog-sidecar` both declare `windows` as an
unconditional dependency:
[dependencies.windows]
...
Cargo builds dependencies for every target, so the `windows` crate is
compiled on non-Windows platforms even though it is only ever used from
modules gated behind `#[cfg(target_os = "windows")]`
(`spawn_worker::win32` and `datadog_sidecar::windows`).
The `windows` crate carries architecture-specific definitions and does
not compile on every Rust target. On a target it does not support
(e.g. FreeBSD/powerpc64) the build fails with errors such as:
error[E0425]: cannot find type `CONTEXT` in this scope
error[E0425]: cannot find type `SLIST_HEADER` in this scope
This goes unnoticed on x86_64/aarch64 because the crate happens to
compile there.
Move the dependency under `[target.'cfg(windows)'.dependencies]` so
cargo only builds it on Windows, matching how it is actually used. The
workspace's other `windows`-crate users (`libdd-crashtracker`,
`libdd-crashtracker-ffi`, `libdd-telemetry`) already gate it this way.
bantonsson
force-pushed
the
external-pr/pr2020
branch
from
960ecfb to
d0af024
Compare
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: waiting
and removed
mergequeue-status: removed
labels
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External Contribution
PR #2020
What does this PR do?
spawn_workeranddatadog-sidecarboth declarewindowsas anunconditional dependency:
Cargo builds dependencies for every target, so the
windowscrate iscompiled on non-Windows platforms even though it is only ever used from
modules gated behind
#[cfg(target_os = "windows")](
spawn_worker::win32anddatadog_sidecar::windows).The
windowscrate carries architecture-specific definitions and doesnot compile on every Rust target. On a target it does not support
(e.g. FreeBSD/powerpc64) the build fails with errors such as:
This goes unnoticed on x86_64/aarch64 because the crate happens to
compile there.
Move the dependency under
[target.'cfg(windows)'.dependencies]socargo only builds it on Windows, matching how it is actually used. The
workspace's other
windows-crate users (libdd-crashtracker,libdd-crashtracker-ffi,libdd-telemetry) already gate it this way.Motivation
Building on FreeBSD/powerpc64le.
How to test the change?
Build outside of x86_64/aarch64.