ci: bump msrv to 1.87.0#2017
Conversation
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: ff5468a | Docs | Datadog PR Page | Give us feedback! |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2017 +/- ##
==========================================
- Coverage 72.80% 72.79% -0.01%
==========================================
Files 458 458
Lines 75789 75789
==========================================
- Hits 55177 55171 -6
- Misses 20612 20618 +6
🚀 New features to boost your workflow:
|
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b84f19e750
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| # If these are set witih value and description, then it gives you UI elements | ||
| DOWNSTREAM_BRANCH: | ||
| value: "main" | ||
| value: "julio/bump-msrv" |
There was a problem hiding this comment.
Changing DOWNSTREAM_BRANCH from main to julio/bump-msrv makes all downstream GitLab triggers default to a personal feature branch instead of the canonical branch. In the reviewed .gitlab-ci.yml pipeline, this means manual/triggered downstream jobs will run against the wrong ref (or fail once that branch is deleted), which can block or misroute release/build workflows until someone overrides the variable each time.
Useful? React with 👍 / 👎.
|
/merge |
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: in_progress
mergequeue-status: error
and removed
mergequeue-status: in_progress
labels
hoolioh
added
skip-metadata-check
skip-pr-title-semver-check
and removed
run-all-tests
labels
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
error while getting head build completion result DetailsError: There was an error while retrieving the result for pipeline 114783235 FullStacktrace: |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
4 participants
What does this PR do?
Bumps the workspace MSRV from 1.84.1 → 1.87.0 and introduces two
single-source-of-truth files at the repo root that all CI workflows now read
from:
rust-toolchain.toml— pins the stable MSRV. Rustup auto-installs it onfirst invocation in the workspace tree (locally and on GitHub-hosted
runners), so contributors no longer need to manually
rustup installtheMSRV to build the workspace.
nightly-toolchain.toml— placeholder file (not read by rustup) that holdsthe dated nightly used by workflows requiring nightly features (rustfmt
unstable options, miri, cargo-bolero, cargo-llvm-cov doc-test coverage,
cargo-public-api).
Future MSRV / nightly bumps now touch a single file each instead of being
sprinkled across ~10 workflows and 3 helper-crate manifests.
Changes
MSRV bump (1.84.1 → 1.87.0)
Cargo.toml: workspacerust-version.github/actions/{ci-shared,clippy-annotation-reporter,crates-reporter}/Cargo.toml:three standalone helper crates that don't inherit from the workspace
README.md: build dependency lineNew source-of-truth files
rust-toolchain.toml(new):channel = "1.87.0", profile minimal, withrustfmt + clippy components
nightly-toolchain.toml(new):channel = "nightly-2026-02-08"RUSTUP_TOOLCHAINoverridesrust-toolchain.toml's pin overridesrustup defaultinside the workspacetree. Workflows that need to run on a different toolchain (the nightly
matrix entries above, plus the 1.92.0 toolchain in
pr-title-semver-check)now set
RUSTUP_TOOLCHAINon the relevant step so the chosen toolchainactually takes effect. Without this, all matrix entries silently collapsed to
MSRV.
Cross-repo dependency
This PR is paired with libddprof-build which adds a
rustup-initlayer to the centos/ubuntu build images and generalizes the macOS rust-setup
block to all platforms. Until the libddprof-build PR lands and
docker_build_jobis triggered to publish image version 30, libddprof-buildCI on centos/ubuntu lacks the rustup fallback and could fail if MSRV bumps
further during the gap. The current bump (1.84.1 → 1.87.0) works because the
libddprof-build PR's v30 images bake exactly 1.87.0.
Motivation
Before this change the MSRV string
"1.84.1"lived in: workspaceCargo.toml,README, three helper-crate
Cargo.tomls under.github/actions/, and fiveGitHub Actions workflows. The nightly date string lived in seven more
workflows. Bumps were error-prone and easy to miss in one location.
In tandem, the companion libddprof-build PR teaches its CI to read
rust-toolchain.tomlat CI time, so MSRV bumps in libdatadog propagate to therelease-artifact builder automatically with a
WARNING-then-rustup-installfallback during the image-refresh window.