Skip to content

feat(client-stats): expose css obfuscation param#225

Draft
Eldolfin wants to merge 8 commits into
mainfrom
oscarld/css-client-obfuscation-exp
Draft

feat(client-stats): expose css obfuscation param#225
Eldolfin wants to merge 8 commits into
mainfrom
oscarld/css-client-obfuscation-exp

Conversation

@Eldolfin
Copy link
Copy Markdown

@Eldolfin Eldolfin commented May 12, 2026

What does this PR do?

Expose the experimental client side stats obfuscation for internal testing/benchmarking.

Motivation

What inspired you to submit this pull request?

Additional Notes

TODO:

  • put back actual crate versions when libdatadog gets bumped

APMSP-2969

@Eldolfin Eldolfin marked this pull request as ready for review May 13, 2026 13:26
@Eldolfin Eldolfin requested a review from a team as a code owner May 13, 2026 13:26
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b3818d7c14

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
libdd-common = { version = "3.0.1", default-features = false }
libdd-tinybytes = { version = "1.1.0", default-features = false }
libdd-library-config = { version = "1.1.0", default-features = false }
libdd-capabilities-impl = { git = "https://github.com/DataDog/libdatadog",rev = "c7131222cb42dd0513821456a4071245c4a819f6", default-features = false }
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add registry versions for git dependencies

When packaging or publishing datadog-opentelemetry, these workspace dependencies are inherited by the crate and Cargo treats git-only normal dependencies as non-publishable. The Cargo Book states crates.io does not allow dependencies on code outside crates.io, and the supported fallback is to specify both git and version so local builds use git while published crates use the registry version. Without version entries here, any release/package step will be blocked until these dependencies are rewritten.

Useful? React with 👍 / 👎.

@Eldolfin Eldolfin marked this pull request as draft May 15, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant