HEDNS fails HTTP/ech= test

[TomOnTime]

Describe the bug
HEDNS fails the testgroup("Ech", test.

To Reproduce

$ go test -run TestDNSProviders -timeout 50m -v -verbose -profile HEDNS -start 18 -end 18
=== RUN   TestDNSProviders
Testing Profile="HEDNS" (TYPE="HEDNS")
=== RUN   TestDNSProviders/dnscontrol.net
=== RUN   TestDNSProviders/dnscontrol.net/Clean_Slate:Empty
    helpers_integration_test.go:236: 
        - DELETE dnscontrol.net HTTPS 1 example.com. alpn=h2,h3 ttl=300
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Create_a_HTTPS_record
    helpers_integration_test.go:236: 
        + CREATE dnscontrol.net HTTPS 1 example.com. alpn=h2,h3 ttl=300
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Add_an_ECH_key
    helpers_integration_test.go:236: 
        ± MODIFY dnscontrol.net HTTPS (1 example.com. alpn=h2,h3 ttl=300) -> (1 example.com. alpn=h2,h3 ech=some+base64+encoded+value/// ttl=300)
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Ignore_the_ECH_key_while_changing_other_values
    helpers_integration_test.go:236: 
        ± MODIFY dnscontrol.net HTTPS (1 example.com. alpn=h2,h3 ech=some+base64+encoded+value/// ttl=300) -> (1 example.net. port=80 ech="some+base64+encoded+value///" ttl=300)
    helpers_integration_test.go:257: Expected 0 corrections on second run, but found 1.
    helpers_integration_test.go:259: UNEXPECTED #0: ± MODIFY dnscontrol.net HTTPS (1 example.net. port=80 ech=some+base64+encoded+value/// ttl=300) -> (1 example.net. port=80 ech="some+base64+encoded+value///" ttl=300)
--- FAIL: TestDNSProviders (34.46s)
    --- FAIL: TestDNSProviders/dnscontrol.net (32.37s)
        --- PASS: TestDNSProviders/dnscontrol.net/Clean_Slate:Empty (5.44s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Create_a_HTTPS_record (9.37s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Add_an_ECH_key (8.95s)
        --- FAIL: TestDNSProviders/dnscontrol.net/18:Ech:Ignore_the_ECH_key_while_changing_other_values (8.60s)
FAIL
exit status 1
FAIL	github.com/DNSControl/dnscontrol/v4/integrationTest	34.951s

Expected behavior
The test passes

DNS Provider

• HEDNS

Additional context
Add any other context about the problem here.

[rblenkinsopp]

I can' reproduce this locally. I've tested by having the testing creditials locally and reverting #4329 (the HEDNS ECH test disable) and I get output below.

Looking further, I think the issue you saw might have already been resolved by #4324?

go test -run TestDNSProviders -timeout 5m -v -verbose -profile HEDNS -start 18 -end 18
=== RUN   TestDNSProviders
=== RUN   TestDNSProviders
Testing Profile="HEDNS" (TYPE="HEDNS")
=== RUN   TestDNSProviders/dnscontrol.net
=== RUN   TestDNSProviders/dnscontrol.net/Clean_Slate:Empty
    helpers_integration_test.go:236: 
        - DELETE ech.dnscontrol.net HTTPS 1 example.com. ech=some+base64+encoded+value/// ttl=300
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Create_a_HTTPS_record
    helpers_integration_test.go:236: 
        + CREATE dnscontrol.net HTTPS 1 example.com. alpn=h2,h3 ttl=300
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Add_an_ECH_key
    helpers_integration_test.go:236: 
        ± MODIFY dnscontrol.net HTTPS (1 example.com. alpn=h2,h3 ttl=300) -> (1 example.com. alpn=h2,h3 ech=some+base64+encoded+value/// ttl=300)
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Ignore_the_ECH_key_while_changing_other_values
    helpers_integration_test.go:236: 
        ± MODIFY dnscontrol.net HTTPS (1 example.com. alpn=h2,h3 ech=some+base64+encoded+value/// ttl=300) -> (1 example.net. port=80 ech=some+base64+encoded+value/// ttl=300)
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Change_the_ECH_key_and_other_values
    helpers_integration_test.go:236: 
        ± MODIFY dnscontrol.net HTTPS (1 example.net. port=80 ech=some+base64+encoded+value/// ttl=300) -> (1 example.org. port=80 ipv4hint=127.0.0.1 ech=another+base64+encoded+value ttl=300)
=== RUN   TestDNSProviders/dnscontrol.net/18:Ech:Another_domain_with_a_different_ECH_value
    helpers_integration_test.go:236: 
        - DELETE dnscontrol.net HTTPS 1 example.org. port=80 ipv4hint=127.0.0.1 ech=another+base64+encoded+value ttl=300
    helpers_integration_test.go:236: 
        + CREATE ech.dnscontrol.net HTTPS 1 example.com. ech=some+base64+encoded+value/// ttl=300
--- PASS: TestDNSProviders (60.85s)
    --- PASS: TestDNSProviders/dnscontrol.net (58.38s)
        --- PASS: TestDNSProviders/dnscontrol.net/Clean_Slate:Empty (5.47s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Create_a_HTTPS_record (9.59s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Add_an_ECH_key (9.19s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Ignore_the_ECH_key_while_changing_other_values (9.63s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Change_the_ECH_key_and_other_values (12.90s)
        --- PASS: TestDNSProviders/dnscontrol.net/18:Ech:Another_domain_with_a_different_ECH_value (11.59s)
PASS
ok  	github.com/DNSControl/dnscontrol/v4/integrationTest	60.946s

[TomOnTime]

• Vizzini: "He didn't fall? Inconceivable!"
• Inigo Montoya: "You keep using that word. I do not think it means what you think it means."

I swear it failed without that change! Oh well, it definitely works now.

Thanks for helping me with this "inconceivable" issue!