fix(unit-tests): added unit tests for preprint-submissions

Author: nsemets

src/app/features/moderation/components/preprint-submissions/preprint-submissions.component.spec.ts

@@ -1,18 +1,24 @@
+import { Store } from '@ngxs/store';
+
 import { MockComponents, MockProvider } from 'ng-mocks';
 
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { ActivatedRoute, Router } from '@angular/router';
 
 import { PreprintSubmissionItemComponent } from '@osf/features/moderation/components';
-import { RegistryModeration } from '@osf/features/moderation/models';
+import { PreprintSubmissionModel } from '@osf/features/moderation/models';
 import { CustomPaginatorComponent, IconComponent, LoadingSpinnerComponent, SelectComponent } from '@shared/components';
 
 import { PreprintSubmissionsSort, SubmissionReviewStatus } from '../../enums';
-import { PreprintModerationSelectors } from '../../store/preprint-moderation';
+import {
+  GetPreprintSubmissionContributors,
+  LoadMorePreprintSubmissionContributors,
+  PreprintModerationSelectors,
+} from '../../store/preprint-moderation';
 
 import { PreprintSubmissionsComponent } from './preprint-submissions.component';
 
-import { MOCK_REGISTRY_MODERATIONS } from '@testing/mocks/registry-moderation.mock';
+import { MOCK_PREPRINT_SUBMISSIONS } from '@testing/mocks/preprint-submission.mock';
 import { OSFTestingModule } from '@testing/osf.testing.module';
 import { ActivatedRouteMockBuilder } from '@testing/providers/route-provider.mock';
 import { RouterMockBuilder } from '@testing/providers/router-provider.mock';
@@ -23,9 +29,10 @@ describe('PreprintSubmissionsComponent', () => {
   let fixture: ComponentFixture<PreprintSubmissionsComponent>;
   let mockRouter: ReturnType<RouterMockBuilder['build']>;
   let mockActivatedRoute: ReturnType<ActivatedRouteMockBuilder['build']>;
+  let store: Store;
 
   const mockProviderId = 'test-provider-id';
-  const mockSubmissions: RegistryModeration[] = MOCK_REGISTRY_MODERATIONS;
+  const mockSubmissions: PreprintSubmissionModel[] = MOCK_PREPRINT_SUBMISSIONS;
 
   beforeEach(async () => {
     mockRouter = RouterMockBuilder.create().build();
@@ -64,6 +71,7 @@ describe('PreprintSubmissionsComponent', () => {
 
     fixture = TestBed.createComponent(PreprintSubmissionsComponent);
     component = fixture.componentInstance;
+    store = TestBed.inject(Store);
     fixture.detectChanges();
   });
 
@@ -143,4 +151,22 @@ describe('PreprintSubmissionsComponent', () => {
     expect(component.currentPage()).toBe(1);
     expect(component.first()).toBe(0);
   });
+
+  it('should load contributors for a submission', () => {
+    const mockItem = mockSubmissions[0];
+    const dispatchSpy = jest.spyOn(store, 'dispatch');
+
+    component.loadContributors(mockItem);
+
+    expect(dispatchSpy).toHaveBeenCalledWith(new GetPreprintSubmissionContributors(mockItem.id));
+  });
+
+  it('should load more contributors for a submission', () => {
+    const mockItem = mockSubmissions[0];
+    const dispatchSpy = jest.spyOn(store, 'dispatch');
+
+    component.loadMoreContributors(mockItem);
+
+    expect(dispatchSpy).toHaveBeenCalledWith(new LoadMorePreprintSubmissionContributors(mockItem.id));
+  });
 });

src/app/features/moderation/components/preprint-withdrawal-submissions/preprint-withdrawal-submissions.component.spec.ts

@@ -1,3 +1,5 @@
+import { Store } from '@ngxs/store';
+
 import { MockComponents, MockProvider } from 'ng-mocks';
 
 import { ComponentFixture, TestBed } from '@angular/core/testing';
@@ -8,7 +10,11 @@ import { PreprintWithdrawalSubmission } from '@osf/features/moderation/models';
 import { CustomPaginatorComponent, IconComponent, LoadingSpinnerComponent, SelectComponent } from '@shared/components';
 
 import { PreprintSubmissionsSort, SubmissionReviewStatus } from '../../enums';
-import { PreprintModerationSelectors } from '../../store/preprint-moderation';
+import {
+  GetPreprintWithdrawalSubmissionContributors,
+  LoadMorePreprintWithdrawalSubmissionContributors,
+  PreprintModerationSelectors,
+} from '../../store/preprint-moderation';
 
 import { PreprintWithdrawalSubmissionsComponent } from './preprint-withdrawal-submissions.component';
 
@@ -23,6 +29,7 @@ describe('PreprintWithdrawalSubmissionsComponent', () => {
   let fixture: ComponentFixture<PreprintWithdrawalSubmissionsComponent>;
   let mockRouter: ReturnType<RouterMockBuilder['build']>;
   let mockActivatedRoute: ReturnType<ActivatedRouteMockBuilder['build']>;
+  let store: Store;
 
   const mockProviderId = 'test-provider-id';
   const mockSubmissions: PreprintWithdrawalSubmission[] = MOCK_PREPRINT_WITHDRAWAL_SUBMISSIONS;
@@ -74,6 +81,7 @@ describe('PreprintWithdrawalSubmissionsComponent', () => {
 
     fixture = TestBed.createComponent(PreprintWithdrawalSubmissionsComponent);
     component = fixture.componentInstance;
+    store = TestBed.inject(Store);
     fixture.detectChanges();
   });
 
@@ -164,4 +172,26 @@ describe('PreprintWithdrawalSubmissionsComponent', () => {
     expect(component.currentPage()).toBe(1);
     expect(component.first()).toBe(0);
   });
+
+  it('should load contributors for a withdrawal submission', () => {
+    const mockItem = mockSubmissions[0];
+    const dispatchSpy = jest.spyOn(store, 'dispatch');
+
+    component.loadContributors(mockItem);
+
+    expect(dispatchSpy).toHaveBeenCalledWith(
+      new GetPreprintWithdrawalSubmissionContributors(mockItem.id, mockItem.preprintId)
+    );
+  });
+
+  it('should load more contributors for a withdrawal submission', () => {
+    const mockItem = mockSubmissions[0];
+    const dispatchSpy = jest.spyOn(store, 'dispatch');
+
+    component.loadMoreContributors(mockItem);
+
+    expect(dispatchSpy).toHaveBeenCalledWith(
+      new LoadMorePreprintWithdrawalSubmissionContributors(mockItem.id, mockItem.preprintId)
+    );
+  });
 });

src/testing/mocks/index.ts

@@ -25,6 +25,7 @@ export { MOCK_REGISTRATION } from './registration.mock';
 export * from './resource.mock';
 export { MOCK_REVIEW } from './review.mock';
 export { MOCK_SCOPES } from './scope.mock';
+export * from './submission.mock';
 export { MOCK_TOKEN } from './token.mock';
 export { TranslateServiceMock } from './translate.service.mock';
 export * from './view-only-link.mock';

src/testing/mocks/preprint-submission.mock.ts

@@ -0,0 +1,70 @@
+import { PreprintSubmissionModel } from '@osf/features/moderation/models';
+
+export const MOCK_PREPRINT_SUBMISSIONS: PreprintSubmissionModel[] = [
+  {
+    id: '1',
+    title: 'Test Preprint Submission 1',
+    reviewsState: 'pending',
+    public: false,
+    actions: [
+      {
+        id: '1',
+        trigger: 'manual',
+        fromState: 'pending',
+        toState: 'pending',
+        dateModified: '2023-01-01',
+        creator: {
+          id: 'user-1',
+          name: 'John Doe',
+        },
+        comment: 'Test comment',
+      },
+    ],
+    contributors: [],
+    totalContributors: 0,
+  },
+  {
+    id: '2',
+    title: 'Test Preprint Submission 2',
+    reviewsState: 'accepted',
+    public: true,
+    actions: [
+      {
+        id: '2',
+        trigger: 'manual',
+        fromState: 'pending',
+        toState: 'accepted',
+        dateModified: '2023-01-02',
+        creator: {
+          id: 'user-2',
+          name: 'Jane Doe',
+        },
+        comment: 'Approved submission',
+      },
+    ],
+    contributors: [],
+    totalContributors: 0,
+  },
+  {
+    id: '3',
+    title: 'Test Preprint Submission 3',
+    reviewsState: 'rejected',
+    public: false,
+    actions: [
+      {
+        id: '3',
+        trigger: 'manual',
+        fromState: 'pending',
+        toState: 'rejected',
+        dateModified: '2023-01-03',
+        creator: {
+          id: 'user-3',
+          name: 'Bob Smith',
+        },
+        comment: 'Rejected submission',
+      },
+    ],
+    contributors: [],
+    totalContributors: 0,
+  },
+];

src/testing/mocks/preprint-withdrawal-submission.mock.ts

@@ -5,6 +5,10 @@ export const MOCK_PREPRINT_WITHDRAWAL_SUBMISSIONS: PreprintWithdrawalSubmission[
     id: '1',
     title: 'Test Withdrawal 1',
     preprintId: 'preprint-1',
+    contributors: [],
+    contributorsLoading: false,
+    contributorsPage: 1,
+    totalContributors: 0,
     actions: [
       {
         id: '1',
@@ -24,6 +28,10 @@ export const MOCK_PREPRINT_WITHDRAWAL_SUBMISSIONS: PreprintWithdrawalSubmission[
     id: '2',
     preprintId: 'preprint-2',
     title: 'Test Withdrawal 2',
+    contributors: [],
+    contributorsLoading: false,
+    contributorsPage: 1,
+    totalContributors: 0,
     actions: [
       {
         id: '2',
@@ -43,6 +51,10 @@ export const MOCK_PREPRINT_WITHDRAWAL_SUBMISSIONS: PreprintWithdrawalSubmission[
     id: '3',
     preprintId: 'preprint-3',
     title: 'Test Withdrawal 3',
+    contributors: [],
+    contributorsLoading: false,
+    contributorsPage: 1,
+    totalContributors: 0,
     actions: [
       {
         id: '3',