[BUG] incorrect detection of too-large note

[nventuro]

What are you trying to do?

The Galactica team run into an issue on v4 when using notes that hold an array.

The full error is Failed calling external resolver. ErrorObject { code: ServerError(-32702), message: "Assertion failed: Index out of bounds", data: None }

Code Reference

They've managed to create a minimal reproduction here: https://github.com/Galactica-corp/aztec-v4-issue-sample

Aztec Version

v4

OS

No response

Browser (if relevant)

No response

Node Version

No response

Additional Context

No response

[nventuro]

After looking into this we concluded the issue is not the array, but that we have an off by one when detecting maximum note length. The note in the reproduction has a packing length that is one element too long, but instead of detecting that at compile time we get a runtime error.