fix: add missing breakableViewChild method

Author: rushabh-atharva

packages/layout/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ats-form-react-pdf-layout",
-  "version": "4.4.4",
+  "version": "4.4.5",
   "license": "MIT",
   "description": "Resolve document component's layout",
   "author": "Diego Muracciole <diegomuracciole@gmail.com>",

packages/layout/src/steps/resolvePagination.ts

@@ -56,6 +56,37 @@ const warnUnavailableSpace = (node: SafeNode) => {
   );
 };
 
+const breakableViewChild = (children, height, path = '', currentChildren) => {
+  for (let i = 0; i < children.length; i += 1) {
+    if (children[i].type !== 'VIEW') continue;
+
+    if (
+      shouldNodeBreak(
+        children[i],
+        children.slice(i + 1, height),
+        height,
+        currentChildren,
+      )
+    ) {
+      return {
+        child: children[i],
+        path: `${path}/${i}`,
+      };
+    }
+
+    if (children[i].children && children[i].children.length > 0) {
+      const breakable = breakableViewChild(
+        children[i].children,
+        height,
+        `${path}/${i}`,
+        currentChildren,
+      );
+      if (breakable) return breakable;
+    }
+  }
+  return null;
+};
+
 const splitNodes = (height: number, contentArea: number, nodes: SafeNode[]) => {
   const currentChildren: SafeNode[] = [];
   const nextChildren: SafeNode[] = [];
@@ -74,6 +105,12 @@ const splitNodes = (height: number, contentArea: number, nodes: SafeNode[]) => {
       height,
       currentChildren,
     );
+
+    const firstBreakableViewChild =
+      child.children &&
+      child.children.length > 0 &&
+      breakableViewChild(child.children, height, '', currentChildren);
+
     const prevChild = nodes.length > 0 && i > 0 ? nodes[i - 1] : undefined;
     const shouldSplit = height + SAFETY_THRESHOLD < nodeTop + nodeHeight;
     const canWrap = canNodeWrap(child, prevChild, currentChildren);
@@ -97,6 +134,7 @@ const splitNodes = (height: number, contentArea: number, nodes: SafeNode[]) => {
         currentChildren.push(child);
         nextChildren.push(...futureNodes);
         warnUnavailableSpace(child);
+        break;
       } else {
         // We don't want to break non wrapable nodes, so we just let them be.
         const box = Object.assign({}, child.box, {
@@ -110,8 +148,8 @@ const splitNodes = (height: number, contentArea: number, nodes: SafeNode[]) => {
 
         currentChildren.push(...futureFixedNodes);
         nextChildren.push(next, ...futureNodes);
+        break;
       }
-      break;
     }
 
     if (shouldBreak) {
@@ -127,7 +165,7 @@ const splitNodes = (height: number, contentArea: number, nodes: SafeNode[]) => {
       break;
     }
 
-    if (shouldSplit) {
+    if (shouldSplit || firstBreakableViewChild) {
       const [currentChild, nextChild] = split(child, height, contentArea);
 
       // All children are moved to the next page, it doesn't make sense to show the parent on the current page
@@ -137,10 +175,10 @@ const splitNodes = (height: number, contentArea: number, nodes: SafeNode[]) => {
         //   currentChildren.push(child, ...futureFixedNodes);
         //   nextChildren.push(...futureNodes);
         // } else {
-        const box = Object.assign({}, child.box, {
-          top: child.box.top - height,
+        const box = Object.assign({}, nextChild.box, {
+          top: nextChild.box.top - height,
         });
-        const next = Object.assign({}, child, { box });
+        const next = Object.assign({}, nextChild, { box });
 
         currentChildren.push(...futureFixedNodes);
         nextChildren.push(next, ...futureNodes);

packages/renderer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "ats-form-react-pdf-renderer",
-  "version": "4.3.4",
+  "version": "4.3.5",
   "license": "MIT",
   "description": "Create PDF files on the browser and server",
   "author": "Diego Muracciole <diegomuracciole@gmail.com>",
@@ -26,7 +26,7 @@
     "@babel/runtime": "^7.20.13",
     "@react-pdf/fns": "3.1.2",
     "@react-pdf/font": "^4.0.3",
-    "ats-form-react-pdf-layout": "^4.4.4",
+    "ats-form-react-pdf-layout": "^4.4.5",
     "@react-pdf/pdfkit": "^4.0.4",
     "@react-pdf/primitives": "^4.1.1",
     "@react-pdf/reconciler": "^1.1.4",