refactor: remaining coverage (#178)

Author: alexbarnsley

composer.json

@@ -63,7 +63,7 @@
             "vendor/bin/php-cs-fixer fix"
         ],
         "test": [
-            "./vendor/bin/pest --coverage --min=96 --coverage-html=.coverage --coverage-clover=coverage.xml"
+            "./vendor/bin/pest --coverage --min=100 --coverage-html=.coverage --coverage-clover=coverage.xml"
         ]
     },
     "minimum-stability": "dev",

phpunit.xml

@@ -1,11 +1,13 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd" bootstrap="vendor/autoload.php" colors="true" cacheDirectory=".phpunit.cache">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
+         bootstrap="vendor/autoload.php"
+         colors="true"
+         cacheDirectory=".phpunit.cache"
+>
     <testsuites>
-        <testsuite name="Analysis">
-            <directory suffix="Test.php">./tests/Analysis</directory>
-        </testsuite>
-        <testsuite name="Unit">
-            <directory suffix="Test.php">./tests/Unit</directory>
+        <testsuite name="Test Suite">
+            <directory suffix="Test.php">./tests</directory>
         </testsuite>
     </testsuites>
     <source>

src/ByteBuffer/Concerns/Writes/UnsignedInteger.php

@@ -75,7 +75,7 @@ public function writeUInt64(int $value, int $offset = 0): self
     public function writeUInt256($value, int $offset = 0): self
     {
         // Convert the value to a GMP object for handling large numbers
-        if (is_numeric($value) || is_string($value)) {
+        if (is_numeric($value)) {
             $gmpValue = gmp_init($value);
         } elseif ($value instanceof \GMP) {
             $gmpValue = $value;

src/Networks/AbstractNetwork.php

@@ -14,17 +14,9 @@ abstract class AbstractNetwork extends Network implements NetworkInterface
      * @see Network::$base58PrefixMap
      */
     protected $base58PrefixMap = [
-        self::BASE58_WIF           => 'aa', // 170
+        self::BASE58_WIF => 'aa', // 170
     ];
 
-    /**
-     * {@inheritdoc}
-     */
-    public static function __callStatic(string $method, array $args)
-    {
-        return static::factory()->{$method}(...$args);
-    }
-
     /**
      * Create a new network instance.
      *

tests/Unit/ByteBuffer/ByteBufferTest.php

@@ -177,6 +177,13 @@
     expect($buffer->internalSize())->toBe(4 + 11);
 });
 
+it('should fill the buffer starting from a different start point', function () {
+    $buffer = ByteBuffer::new('hello');
+    $buffer->fill(11, 4);
+
+    expect($buffer->internalSize())->toBe(4 + 11);
+});
+
 it('should flip the buffer contents', function () {
     $buffer = ByteBuffer::new('Hello World');
     $buffer->flip();

tests/Unit/ByteBuffer/Concerns/Reads/UnsignedIntegerTest.php

@@ -71,3 +71,13 @@
 
     expect($buffer->readULong())->toBe(64);
 });
+
+test('it should read uint256', function () {
+    // 256-bit unsigned integer (32 bytes)
+    $value  = '1157920892373161954235709850086879078532699846656405640323232344'; // max uint256
+    $buffer = ByteBuffer::new(0);
+    $buffer->writeUInt256($value);
+    $buffer->position(0);
+
+    expect($buffer->readUInt256())->toBe($value);
+});

tests/Unit/ByteBuffer/Concerns/Writes/UnsignedIntegerTest.php

@@ -63,3 +63,35 @@
 
     expect($buffer->internalSize())->toBe(8);
 });
+
+test('it should write uint256', function () {
+    // 256-bit unsigned integer (32 bytes)
+    $value  = '1157920892373161954235709850086879078532699846656405640323232344'; // max uint256
+    $buffer = ByteBuffer::new(0);
+    $buffer->writeUInt256($value);
+
+    expect($buffer->internalSize())->toBe(32);
+});
+
+test('it should write uint256 gmp value', function () {
+    // 256-bit unsigned integer (32 bytes)
+    $value  = gmp_init('1157920892373161954235709850086879078532699846656405640323232344'); // max uint256
+    $buffer = ByteBuffer::new(0);
+    $buffer->writeUInt256($value);
+
+    expect($buffer->internalSize())->toBe(32);
+});
+
+test('it should throw exception when writing invalid uint256', function () {
+    // 256-bit unsigned integer (32 bytes)
+    $value  = 'asd';
+    $buffer = ByteBuffer::new(0);
+    $buffer->writeUInt256($value);
+})->throws(InvalidArgumentException::class, 'The value must be a numeric string, integer, or GMP object.');
+
+test('it should throw exception when writing uint256 which is too long', function () {
+    // 256-bit unsigned integer (32 bytes)
+    $value  = '1157920892373161954235709850086879078532699846656405640323232344444411579208923731619542357098500868790785326998466564056403232323444444';
+    $buffer = ByteBuffer::new(0);
+    $buffer->writeUInt256($value);
+})->throws(InvalidArgumentException::class, 'The value must fit into 256 bits.');

tests/Unit/Enums/AbiFunctionTest.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+
+use ArkEcosystem\Crypto\Enums\AbiFunction;
+use ArkEcosystem\Crypto\Transactions\Types\Multipayment;
+use ArkEcosystem\Crypto\Transactions\Types\Unvote;
+use ArkEcosystem\Crypto\Transactions\Types\UsernameRegistration;
+use ArkEcosystem\Crypto\Transactions\Types\UsernameResignation;
+use ArkEcosystem\Crypto\Transactions\Types\ValidatorRegistration;
+use ArkEcosystem\Crypto\Transactions\Types\ValidatorResignation;
+use ArkEcosystem\Crypto\Transactions\Types\Vote;
+
+it('should get transaction class', function ($type, $class) {
+    expect(constant(AbiFunction::class.'::'.$type)->transactionClass())->toEqual($class);
+})->with([
+    'Vote'                  => ['VOTE', Vote::class],
+    'Unvote'                => ['UNVOTE', Unvote::class],
+    'ValidatorRegistration' => ['VALIDATOR_REGISTRATION', ValidatorRegistration::class],
+    'ValidatorResignation'  => ['VALIDATOR_RESIGNATION', ValidatorResignation::class],
+    'UsernameRegistration'  => ['USERNAME_REGISTRATION', UsernameRegistration::class],
+    'UsernameResignation'   => ['USERNAME_RESIGNATION', UsernameResignation::class],
+    'Multipayment'          => ['MULTIPAYMENT', Multipayment::class],
+]);

tests/Unit/Identities/AddressTest.php

@@ -38,3 +38,17 @@
 
     expect($actual)->toBe($fixture['data']['address']);
 });
+
+it('should validate an address', function () {
+    $fixture = $this->getFixture('identity');
+
+    $actual = Address::validate($fixture['data']['address']);
+
+    expect($actual)->toBeTrue();
+});
+
+it('should return false for an invalid address', function () {
+    $actual = Address::validate('invalid-address');
+
+    expect($actual)->toBeFalse();
+});

tests/Unit/Transactions/Builder/ValidatorRegistrationBuilderTest.php

@@ -42,6 +42,13 @@
     expect((string) $builder)->toBe($builder->toJson());
 });
 
+it('should set value on the transaction', function () {
+    $builder = ValidatorRegistrationBuilder::new()
+        ->value(UnitConverter::parseUnits(10, 'ark'));
+
+    expect((string) $builder->transaction->data['value'])->toBe('10000000000000000000');
+});
+
 it('should convert to an array', function () {
     $fixture = $this->getTransactionFixture('evm_call', 'unvote');