Fix #69: validate form input

Author: AdrienPoupa

app/src/main/java/com/poupa/attestationdeplacement/CreateAttestationActivity.java

@@ -2,6 +2,7 @@
 
 import android.app.ProgressDialog;
 import android.app.TimePickerDialog;
+import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.os.AsyncTask;
@@ -19,6 +20,7 @@
 import androidx.constraintlayout.widget.ConstraintLayout;
 import androidx.constraintlayout.widget.ConstraintSet;
 
+import com.google.android.material.dialog.MaterialAlertDialogBuilder;
 import com.google.android.material.textfield.TextInputEditText;
 import com.poupa.attestationdeplacement.generator.Attestation;
 import com.poupa.attestationdeplacement.generator.AttestationDeplacementDerogatoireGenerator;
@@ -171,13 +173,97 @@ public void onClick(View v) {
      * @param v
      */
     public void startGenerate(View v) {
-        new Thread(new Runnable() {
-            @Override
-            public void run() {
-            final GeneratePdfTask task = new GeneratePdfTask();
-            task.execute();
-            }
-        }).start();
+        boolean valid = checkFields();
+
+        if (valid) {
+            new Thread(new Runnable() {
+                @Override
+                public void run() {
+                    final GeneratePdfTask task = new GeneratePdfTask();
+                    task.execute();
+                }
+            }).start();
+        }
+    }
+
+    public boolean checkFields() {
+        if (surnameInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.surname_missing));
+            return false;
+        }
+
+        if (lastNameInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.lastname_missing));
+            return false;
+        }
+
+        if (birthDateInput.getText().toString().equals("JJ/MM/AAAA")) {
+            displayAlertDialog(getString(R.string.birthdate_missing));
+            return false;
+        }
+
+        if (birthPlaceInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.birthplace_missing));
+            return false;
+        }
+
+        if (addressInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.address_missing));
+            return false;
+        }
+
+        if (cityInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.city_missing));
+            return false;
+        }
+
+        if (postalCodeInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.postal_code_missing));
+            return false;
+        }
+
+        if (travelDateInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.travel_date_missing));
+            return false;
+        }
+
+        if (travelHourInput.getText().toString().isEmpty()) {
+            displayAlertDialog(getString(R.string.travel_hour_missing));
+            return false;
+        }
+
+        if (! ((CheckBox) findViewById(R.id.reason1)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason2)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason3)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason4)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason5)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason6)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason7)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason8)).isChecked() &&
+            ! ((CheckBox) findViewById(R.id.reason9)).isChecked()
+        ) {
+            displayAlertDialog(getString(R.string.reaon_missing));
+            return false;
+        }
+
+        return true;
+    }
+
+    private void displayAlertDialog(String text) {
+        new MaterialAlertDialogBuilder(this)
+                .setTitle(R.string.warning)
+                .setMessage(text)
+                .setPositiveButton(android.R.string.yes, new DialogInterface.OnClickListener() {
+                    public void onClick(DialogInterface dialog, int which) {
+                        dialog.dismiss();
+                    }
+                })
+                .setNegativeButton(android.R.string.no, new DialogInterface.OnClickListener() {
+                    public void onClick(DialogInterface dialog, int which) {
+                        dialog.dismiss();
+                    }
+                })
+                .show();
     }
 
     private class GeneratePdfTask extends AsyncTask<Void, Void, Void> {

app/src/main/res/values/strings.xml

@@ -50,4 +50,14 @@
     <string name="see_pdf">Voir le PDF</string>
     <string name="share">Partager</string>
     <string name="attestation_generated">Attestation générée !</string>
+    <string name="surname_missing">Merci de préciser votre prénom</string>
+    <string name="lastname_missing">Merci de préciser votre nom de famille</string>
+    <string name="birthdate_missing">Merci de préciser votre date de naissance</string>
+    <string name="birthplace_missing">Merci de préciser votre lieu de naissance</string>
+    <string name="address_missing">Merci de préciser votre adresse</string>
+    <string name="city_missing">Merci de préciser votre ville</string>
+    <string name="postal_code_missing">Merci de préciser votre code postal</string>
+    <string name="travel_date_missing">Merci de préciser votre date de sortie</string>
+    <string name="travel_hour_missing">Merci de préciser votre heure de sortie</string>
+    <string name="reaon_missing">Merci de préciser un motif de déplacement</string>
 </resources>