[main/2026-08-26-1240] scr_kill_ship:151

[lyra-the-bot]

Your game just encountered and caught an error!

System Details:

• Date-Time: 26-8-2026 18:22:46
• Game Version: main
• Build Date: 2026-08-26-1240
• Commit Hash: 1b85deb

Save Details:

• Chapter Name: War Chameleons
• Current Turn: 25
• Game Seed: 2582026496

Error Details:

I32 argument is unset

Stacktrace:

• scr_kill_ship:151
• return_lost_ship:85
• return_lost_ships_chance:4
• obj_controller_Alarm_5:633

Reporter:

Quies

User Message:

hitting end turn

[github-actions]

Investigation for #1477 - scr_kill_ship:151 I32 argument is unset

Reproduction path from report

• Stacktrace: scr_kill_ship:151 <- return_lost_ship:85 <- return_lost_ships_chance:4 <- obj_controller_Alarm_5:633 (objects/obj_controller/Alarm_5.gml:633)
• Trigger: End turn with a Lost ship returning. return_lost_ships_chance() (scripts/scr_player_ship_functions/scr_player_ship_functions.gml:1) rolls >97 and calls return_lost_ship(). When _return_defect <= 20 (scripts/scr_player_ship_functions/scr_player_ship_functions.gml:83) the warp-torn ship is destroyed via scr_kill_ship(_return_id) at scripts/scr_player_ship_functions/scr_player_ship_functions.gml:85 (same at line 76 for the Chaos capture path).

Root cause

Typo - wrong variable name at scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:151.

// scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:140-151
for (var i = 0; i < array_length(_units_on_ship); i++) {
    _unit = _units_on_ship[i]; // <- assigned to `_unit`
    _unit.ship_location = -1;
    if (_nearest_star != noone) {
        _unit.location_string = _nearest_star.name;
    } else {
        _unit.location_string = "";
    }
    unit.kill(false, false); // <- BUG: `unit` is unset, should be `_unit`
}

• Loop local is declared as var _unit at scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:5 and correctly used as _unit.kill(false, false) earlier at scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:15.
• At line 151 the underscore prefix is missing. GML resolves unit as local -> instance -> global -> built-in. No var unit exists in scr_kill_ship(), so on that line it is undefined / unset, producing the exact I32 argument is unset error reported. The try/catch at scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:2 / scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:154 catches it via ERROR_HANDLER.handle_exception, which is why you see the "game just encountered and caught an error" dialog.
• Formatter commit 9597a0a is the only commit in this checkout, so git blame attributes all lines to it and hides the introduction, but the typo is present in HEAD:scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:151.

Confirmed no other unit.kill typo in the same file - only scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:15 (correct) and :151 (incorrect).

Proposed fixes

Fix 1 - Minimal (recommended) - correct the variable name

Single-character fix, lowest risk:

// scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:151
-                unit.kill(false, false);
+                _unit.kill(false, false);

Optionally add a defensive guard since _units_on_ship is built from fetch_unit() results which can rarely be non-struct if companies were mutated mid-loop:

for (var i = 0; i < array_length(_units_on_ship); i++) {
    _unit = _units_on_ship[i];
    if (!is_struct(_unit)) {
        continue;
    }
    _unit.ship_location = -1;
    // ...
    _unit.kill(false, false);
}

Fix 2 - Defensive index/body check at entry to scr_kill_ship

Prevents similar out-of-bounds crashes if a stale _return_id is passed (e.g., ship already deleted by scr_ini_ship_cleanup() at scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:165 in same turn):

function scr_kill_ship(index) {
    if ((index < 0) || (index >= array_length(obj_ini.ship))) {
        LOGGER.warning($"scr_kill_ship: invalid index {index}");
        return;
    }
    if (obj_ini.ship[index] == "") {
        return;
    }
    try {
        // existing body
    } catch (_exception) {
        ERROR_HANDLER.handle_exception(_exception);
    }
}

This would also make get_valid_player_ship() returning -1 at scripts/scr_player_ship_functions/scr_player_ship_functions.gml:11 safer if ever missed.

Fix 3 - Lint / naming hygiene (follow docs/CODE_STYLE.md)

Enforce var _ prefix for locals (per docs/CODE_STYLE.md) and avoid bare unit as a local name to prevent shadowing obj_ini instance variables. Add a GoboCat or Feather check for "variable used before declaration" and rename the loop temp at scripts/scr_ini_ship_cleanup/scr_ini_ship_cleanup.gml:140 to avoid reuse of i across sequential for loops (GML var is function-scoped, not block-scoped per docs/GML_REFERENCE.md - reuse of var i and var _unit is legal but noisy). Not required to close the crash, but prevents recurrence.

Verification

• grep -rn "unit.kill" scripts/scr_ini_ship_cleanup/ confirms only line 151 is affected.
• Manual inspection of scripts/scr_kill_unit/scr_kill_unit.gml:48 shows kill_and_recover() expects self to be a TTRPG_stats struct (static kill = kill_and_recover at scripts/scr_marine_struct/scr_marine_struct.gml:2337). Calling on undefined reproduces the I32 error.
• No code change made in this investigation - comment only.

/cc @Adeptus-Dominus

[EttyKitty]

/opencode Implement fix 1 and create a PR.

[opencode-agent]

Created PR #1478

github run