Bugged apothecary aspirant

[EttyKitty]

Game version

Commit: 3ba2801f

Operating System

Windows 10

Description

I had an apothecary aspirant for a while now, when is he supposed to graduate? When he was first selected, the game said on the next turn that "there were no further apothecary applicants", or something like that, and turned off the recruit option. Then the same popup happed every other time. But now, for some reason, it let the recruiting option stay on, but the "time to graduate" is at -12 and going down.

Steps to reproduce

No response

Screenshots

No response

[EttyKitty]

/oc if you can hear me, please, investigate this issue:

1. Retrieve issue details.
2. Inspect and read the repository codebase to locate the root cause.
3. Propose 1-3 solutions/fixes.
4. Post your investigation and proposed fixes.

[opencode-agent]

Investigation: Bugged apothecary aspirant (-12 months to graduate)

Issue: scripts/scr_specialist_training/scr_specialist_training.gml:122 + scripts/scr_apothecarium/scr_apothecarium.gml:100

Commit 13ba2801f. Player reports: apothecary aspirant created, next turn popup “no further apothecary applicants” disables training_apothecary, repeats every other turn, eventually stays enabled with negative ETA (-12 -> decreasing).

Root Cause: apothecary_training() control flow is inverted vs all other specialist trainings

File: scripts/scr_specialist_training/scr_specialist_training.gml:122-184

function apothecary_training() {
    apothecary_recruit_points += training_points_values[training_apothecary]; // :127
    var novice_type = string("{0} Aspirant", _apoth_role.role);
    if (training_apothecary > 0) { // :132
        recruit_count = scr_role_count(novice_type, ""); // :133
        if (apothecary_recruit_points >= 48) { // :135 graduate
            if (recruit_count > 0) { // :136
                var random_marine = scr_random_marine(novice_type, 0);
                if (random_marine == "none") { return; } // :138-139 early return, points not decremented
                apothecary_recruit_points -= 48; // :147
                // ... promote to Apothecary
            } else {
                apothecary_recruit_points = 0; // :165 no aspirant -> reset
            }
        } else if ((apothecary_recruit_points >= 4) && (recruit_count == 0)) { // :167 create aspirant
            var random_marine = spec_data_set(eROLE_TAG.Apothecary);
            if (random_marine == "none") {
                return; // :169-171 BUG2: silent return, training stays ON, points keep accumulating
            }
            // ... assign novice_type
        } else {
            training_apothecary = 0; // :181 BUG1: triggers while *waiting* for graduation
            scr_alert("red", "recruitment", $"No marines available for {obj_ini.player_role_data[eROLE.APOTHECARY].role} training", 0, 0);
        }
    }
}

Compare chaplain_training() scripts/scr_specialist_training/scr_specialist_training.gml:188-252, librarian_training() :256-308, techmarine_training() :312-427:

// chaplain: no outer else
if (training_chaplain > 0) {
    if (chaplain_points >= 48) { /* graduate or reset */ }
    else if ((chaplain_points >=4) && (recruit_count==0)) {
        var random_marine = spec_data_set(eROLE_TAG.Chaplain);
        if (random_marine != "none") { /* create */ chaplain_aspirant=1; }
        else { training_chaplain=0; scr_alert("No remaining ..."); } // correctly disables
    }
    // waiting with aspirant present does nothing -> accumulates to 48
}

Consequences:

1. BUG1 - Spurious disable while aspirant training: When recruit_count==1 and 4 <= points < 48 (normal wait period), neither points>=48 nor points>=4 && count==0 is true -> hits else -> training_apothecary=0 + red alert. This matches report: aspirant selected, next turn “no further applicants” and recruit option turned off. Re-enabling repeats cycle. Observed in scr_income.gml:37-54 and Mouse_50.gml:67-69 training costs.

2. BUG2 - Silent accumulate when no eligible marine: spec_data_set(eROLE_TAG.Apothecary) requires technology>=29 && intelligence>=44 && experience>=60 (Create_0.gml:1211-1230). If none, chaplain/librarian/tech disable training + alert, but apothecary just return -> training_apothecary stays >0, points grow +0.8..4 per turn unbounded.

3. BUG3 - Graduation stall: If points>=48 but scr_random_marine(novice_type,0)=="none" (should not happen when scr_role_count>0 but possible race/fetch failure), early return leaves points>=48. Next turn points+=tier -> 50,52... -> scr_apothecarium.gml:100 ETA becomes negative:

   eta = floor((47 - apothecary_recruit_points) / training_points_values[training_apothecary]) + 1; // :100
   // points=60, tier=1.5 -> floor((47-60)/1.5)+1 = -8 -> displayed as "-12 months" and decreasing

   Training stays on (graduation branch has no else disable), matching final state: recruit option stays on but time to graduate = -12.

Evidence

• glob/grep shows apothecary_aspirant declared Create_0.gml:1147 but never used in training, while chaplain_aspirant/psyker_aspirant/tech_aspirant are maintained.
• History 63a8a1893 fix: Unify no applicant specialists behavior added training=0 to apothecary but kept erroneous else; later refactors 34409de00 preserved bug.
• ETA calc lacks clamp/div-by-zero guard when training_apothecary==0 (global.apothecary_training_tiers[0]==0).

Proposed Fixes (pick one)

Option 1 - Minimal, mirror chaplain (recommended)

Remove outer else, fix none handling:

function apothecary_training() {
    apothecary_recruit_points += training_points_values[training_apothecary];
    var _apoth_role = obj_ini.player_role_data[eROLE.APOTHECARY];
    var novice_type = string("{0} Aspirant", _apoth_role.role);
    if (training_apothecary > 0) {
        var recruit_count = scr_role_count(novice_type, "");
        if (apothecary_recruit_points >= 48) {
            if (recruit_count > 0) {
                var random_marine = scr_random_marine(novice_type, 0);
                if (random_marine == "none") { return; } // or LOG.error + apothecary_recruit_points = 48;
                var _unit = fetch_unit(random_marine);
                if (!is_struct(_unit)) { return; }
                apothecary_recruit_points -= 48;
                scr_alert("green","recruitment", _unit.name_role()+" has finished training.",0,0);
                _unit.update_role(_apoth_role.role);
                _unit.role_tag=[0,0,0,0];
                _unit.add_exp(10);
                var _outcome = _unit.alter_equipment(_apoth_role, true, true);
                if (!_outcome.success) scr_alert("red","recruitment",$"{_outcome.description}!",0,0);
            } else {
                apothecary_recruit_points = 0;
            }
        } else if ((apothecary_recruit_points >= 4) && (recruit_count == 0)) {
            var random_marine = spec_data_set(eROLE_TAG.Apothecary);
            if (random_marine == "none") {
                training_apothecary = 0;
                scr_alert("red","recruitment",$"No marines available for {_apoth_role.role} training",0,0);
                return;
            }
            var _unit = fetch_unit(random_marine);
            if (!is_struct(_unit)) {
                training_apothecary = 0;
                scr_alert("red","recruitment",$"No marines available for {_apoth_role.role} training",0,0);
                return;
            }
            _unit.move_to_company(0);
            _unit.update_role(novice_type);
            _unit.update_gear("");
            _unit.update_mobility_item("");
            scr_alert("green","recruitment", _unit.name_role()+" begins training.",0,0);
        }
        // no else - waiting period is intentional
    }
}

Pros: 1-line logical change, consistent with other specialists, fixes report's -12 and popup spam. Cons: Does not auto-recover saves already stuck at points>48.

Option 2 - Comprehensive + save recovery

Same as Option 1, plus:

• Graduation none branch: LOGGER.error(...) and apothecary_recruit_points = min(apothecary_recruit_points, 48) to allow retry next turn instead of unbounded growth.
• Clamp ETA scr_apothecarium.gml:100: eta = max(1, floor((47 - apothecary_recruit_points)/tier)+1) and guard tier==0 -> eta=0 / display "HALTED".
• Optional migration on load: if apothecary_recruit_points>60 set to 47 and if scr_role_count(novice_type)>0 keep training_apothecary.

Pros: Defensive, recovers broken saves. Cons: Larger diff.

Option 3 - UI-only hotfix

Only clamp scr_apothecarium.gml:100 and add if (training_apothecary==0) eta=0: hides negative ETA but leaves training loop broken (will still disable each turn).

Pros: Tiny. Cons: Does not fix root cause, poor UX.

Recommendation: Option 1 (or 2 for robustness). File to edit: scripts/scr_specialist_training/scr_specialist_training.gml:167-183. Secondary fix scripts/scr_apothecarium/scr_apothecarium.gml:99-101 for ETA display.

github run