fix: bulk armour painting and complex livery selection - #1452
Merged
Conversation
Collaborator
Author
|
\review |
Contributor
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Fixes bulk armour painting and complex livery selection by splitting handling and using enums. Previously both modes misapplied colours and didn’t refresh controls; now Bulk updates role colours and buttons, Advanced updates per-area colours and buttons, with improved spacing and no popup tooltips.
eLIVERY_COLOURING_OPTIONSandeLIVERY_SELECTION_TYPES; replaces numeric checks in the popup flow,scr_livery_setup, and selection radios.bulk_selection_buttons_setup(); Advanced writescomplex_livery_data[role][area]and callsset_complex_livery_buttons().scr_livery_setup: branches on Standard/Bulk/Advanced via enums, hides role/company radios in Advanced, moves controls down (~y=220+), anchors Bulk “Update Sprite” to the preview box, positions Bulk armour pattern below the last button, and usesfnt_40k_14bfor selection UIs.tooltipfields and the popup tooltip drawing block fromobj_creation_popup.Migration
eLIVERY_COLOURING_OPTIONS/eLIVERY_SELECTION_TYPES.Written for commit 7a1eeef. Summary will update on new commits.